github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 12:58:36 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #5494] [MERGED] [PM-22744] Refactor to use CipherListView as primary cipher source #47417

New Issue
Closed
opened 2026-04-26 14:58:57 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 14:58:57 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5494
Author: @SaintPatrck
Created: 7/8/2025
Status: ✅ Merged
Merged: 7/22/2025
Merged by: @SaintPatrck

Base: main ← Head: PM-22744/integrate-cipher-list-view-as-primary-cipher-source

📝 Commits (10+)

  • 5e08af4 [PM-22744] Refactor to use CipherListView as primary cipher source
  • 2813c47 Merge remote-tracking branch 'origin/main' into PM-22744/integrate-cipher-list-view-as-primary-cipher-source
  • c2b52c8 Reduce code duplication in VaultItemListingViewModel
  • c4cb689 Merge remote-tracking branch 'origin/main' into PM-22744/integrate-cipher-list-view-as-primary-cipher-source
  • 5c82d29 Merge remote-tracking branch 'origin/main' into PM-22744/integrate-cipher-list-view-as-primary-cipher-source
  • 950109e Merge remote-tracking branch 'origin/main' into PM-22744/integrate-cipher-list-view-as-primary-cipher-source
  • dffc95d [PM-23681] Update TotpCodeManager to use CipherListView
  • 388725e Unshelve stashed changes
  • 402540a Refactor: Remove CipherView overloads from TotpCodeManager
  • b9f44af Update getCredentialEntries for public key credential options

📊 Changes

48 files changed (+3336 additions, -2215 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/provider/AutofillCipherProviderImpl.kt (+47 -23)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/util/CipherListViewExtensions.kt (+6 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/credentials/manager/BitwardenCredentialManagerImpl.kt (+49 -31)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/ciphermatching/CipherMatchingManager.kt (+4 -4)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/ciphermatching/CipherMatchingManagerImpl.kt (+15 -14)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSource.kt (+0 -24)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSourceImpl.kt (+0 -22)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/di/VaultSdkModule.kt (+0 -5)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/model/Fido2CredentialStoreImpl.kt (+74 -59)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/TotpCodeManager.kt (+0 -17)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/TotpCodeManagerImpl.kt (+0 -120)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepository.kt (+10 -18)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt (+61 -79)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/model/VaultData.kt (+3 -6)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/SearchViewModel.kt (+133 -54)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/util/SearchTypeDataExtensions.kt (+40 -28)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt (+66 -16)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt (+265 -168)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/model/ListingItemOverflowAction.kt (+2 -4)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataExtensions.kt (+41 -43)

...and 28 more files

📄 Description

🎟️ Tracking

PM-22744

📔 Objective

Use CipherListView as the primary source of decrypted ciphers.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5494 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 7/8/2025 **Status:** ✅ Merged **Merged:** 7/22/2025 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `PM-22744/integrate-cipher-list-view-as-primary-cipher-source` --- ### 📝 Commits (10+) - [`5e08af4`](https://github.com/bitwarden/android/commit/5e08af459888e89a262b0544818bbf67df8d0a79) [PM-22744] Refactor to use CipherListView as primary cipher source - [`2813c47`](https://github.com/bitwarden/android/commit/2813c47c2d3aa3368b7be05fc7b60ac102dd89c2) Merge remote-tracking branch 'origin/main' into PM-22744/integrate-cipher-list-view-as-primary-cipher-source - [`c2b52c8`](https://github.com/bitwarden/android/commit/c2b52c856cac5fa2798a952cfa1127979c93a4d7) Reduce code duplication in VaultItemListingViewModel - [`c4cb689`](https://github.com/bitwarden/android/commit/c4cb6892be364edfc5ee4345fd2c1ba1891931d0) Merge remote-tracking branch 'origin/main' into PM-22744/integrate-cipher-list-view-as-primary-cipher-source - [`5c82d29`](https://github.com/bitwarden/android/commit/5c82d296e5d92cde641ce383b2e9bdf6dadb57ab) Merge remote-tracking branch 'origin/main' into PM-22744/integrate-cipher-list-view-as-primary-cipher-source - [`950109e`](https://github.com/bitwarden/android/commit/950109ef8736373356fac438a7871973d806a451) Merge remote-tracking branch 'origin/main' into PM-22744/integrate-cipher-list-view-as-primary-cipher-source - [`dffc95d`](https://github.com/bitwarden/android/commit/dffc95d9227fcf4df4f15f0874f1643a06d30466) [PM-23681] Update TotpCodeManager to use CipherListView - [`388725e`](https://github.com/bitwarden/android/commit/388725e45a51a77fe270bcdd28aa95d1feaed616) Unshelve stashed changes - [`402540a`](https://github.com/bitwarden/android/commit/402540a9a5e42ce31e07fd64552d4f936e379c23) Refactor: Remove CipherView overloads from TotpCodeManager - [`b9f44af`](https://github.com/bitwarden/android/commit/b9f44afc2ce6ae253684c2486df4ddc060e77abc) Update `getCredentialEntries` for public key credential options ### 📊 Changes **48 files changed** (+3336 additions, -2215 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/provider/AutofillCipherProviderImpl.kt` (+47 -23) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/util/CipherListViewExtensions.kt` (+6 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/credentials/manager/BitwardenCredentialManagerImpl.kt` (+49 -31) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/ciphermatching/CipherMatchingManager.kt` (+4 -4) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/ciphermatching/CipherMatchingManagerImpl.kt` (+15 -14) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSource.kt` (+0 -24) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/VaultSdkSourceImpl.kt` (+0 -22) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/di/VaultSdkModule.kt` (+0 -5) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/sdk/model/Fido2CredentialStoreImpl.kt` (+74 -59) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/TotpCodeManager.kt` (+0 -17) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/TotpCodeManagerImpl.kt` (+0 -120) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepository.kt` (+10 -18) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt` (+61 -79) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/model/VaultData.kt` (+3 -6) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/SearchViewModel.kt` (+133 -54) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/platform/feature/search/util/SearchTypeDataExtensions.kt` (+40 -28) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt` (+66 -16) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/VaultItemListingViewModel.kt` (+265 -168) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/model/ListingItemOverflowAction.kt` (+2 -4) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/itemlisting/util/VaultItemListingDataExtensions.kt` (+41 -43) _...and 28 more files_ </details> ### 📄 Description ## 🎟️ Tracking PM-22744 ## 📔 Objective Use `CipherListView` as the primary source of decrypted ciphers. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 14:58:57 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#47417
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?