github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-16 16:57:18 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4156] [MERGED] BITAU-182 BITAU-107 Don't show authetnicator sync toggle below API 31 #4732

New Issue
Closed
opened 2025-11-26 23:49:00 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:49:00 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4156
Author: @ahaisting-livefront
Created: 10/24/2024
Status: ✅ Merged
Merged: 10/25/2024
Merged by: @ahaisting-livefront

Base: main ← Head: allow-sync-toggle-updates

📝 Commits (2)

  • 05c970b BITAU-182 BITAU-107 Don't show authetnicator sync toggle when below API 31
  • e6100e6 Test updates based on feedback

📊 Changes

5 files changed (+63 additions, -9 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityViewModel.kt (+8 -4)
📝 app/src/main/res/values/strings.xml (+1 -1)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityScreenTest.kt (+2 -2)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityViewModelTest.kt (+51 -1)
📝 authenticatorbridge/src/main/java/com/bitwarden/authenticatorbridge/util/AndroidBuildUtils.kt (+1 -1)

📄 Description

🎟️ Tracking

https://livefront.atlassian.net/browse/BITAU-182
https://livefront.atlassian.net/browse/BITAU-107

📔 Objective

The goal of this PR is to not show authenticator sync UI when API level is below 31. Also, I made a small copy update that Lukus found while I was in there.

📸 Screenshots

Note: the design file is still using v2 design, so we can ignore that difference.

Design Implementation

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4156 **Author:** [@ahaisting-livefront](https://github.com/ahaisting-livefront) **Created:** 10/24/2024 **Status:** ✅ Merged **Merged:** 10/25/2024 **Merged by:** [@ahaisting-livefront](https://github.com/ahaisting-livefront) **Base:** `main` ← **Head:** `allow-sync-toggle-updates` --- ### 📝 Commits (2) - [`05c970b`](https://github.com/bitwarden/android/commit/05c970bd5266944644382e11f911187db77965ee) BITAU-182 BITAU-107 Don't show authetnicator sync toggle when below API 31 - [`e6100e6`](https://github.com/bitwarden/android/commit/e6100e66a2872b44cacf9fedbc75cf7ac35b5a14) Test updates based on feedback ### 📊 Changes **5 files changed** (+63 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityViewModel.kt` (+8 -4) 📝 `app/src/main/res/values/strings.xml` (+1 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityScreenTest.kt` (+2 -2) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityViewModelTest.kt` (+51 -1) 📝 `authenticatorbridge/src/main/java/com/bitwarden/authenticatorbridge/util/AndroidBuildUtils.kt` (+1 -1) </details> ### 📄 Description ## 🎟️ Tracking https://livefront.atlassian.net/browse/BITAU-182 https://livefront.atlassian.net/browse/BITAU-107 ## 📔 Objective The goal of this PR is to not show authenticator sync UI when API level is below 31. Also, I made a small copy update that Lukus found while I was in there. ## 📸 Screenshots Note: the design file is still using v2 design, so we can ignore that difference. | Design | Implementation | | --- | --- | | <img src="https://github.com/user-attachments/assets/5ae01fe0-7abc-4cf0-a3c8-6c22359394e5" width="300" /> | <img src="https://github.com/user-attachments/assets/b4f0e5a3-8706-46a7-a6a4-0da0d6ad2ccb" width="300" /> | ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:49:00 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4732
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?