github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-10 20:24:12 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4128] [MERGED] BITAU-112 Support deep link into add item flow from Authenticator app #4707

New Issue
Closed
opened 2025-11-26 23:48:40 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:48:40 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4128
Author: @ahaisting-livefront
Created: 10/21/2024
Status: ✅ Merged
Merged: 10/23/2024
Merged by: @ahaisting-livefront

Base: main ← Head: create-add-totp-item-intent

📝 Commits (2)

  • b758884 BITAU-112 Support deep link into add item flow from Authenticator app
  • e615633 Update chain formatting

📊 Changes

15 files changed (+365 additions, -21 deletions)

View changed files

📝 app/libs/authenticatorbridge-0.1.0-SNAPSHOT-release.aar (+0 -0)
📝 app/src/main/java/com/x8bit/bitwarden/MainViewModel.kt (+18 -1)
➕ app/src/main/java/com/x8bit/bitwarden/data/auth/manager/AddTotpItemFromAuthenticatorManager.kt (+15 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/auth/manager/AddTotpItemFromAuthenticatorManagerImpl.kt (+11 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/auth/manager/di/AuthManagerModule.kt (+7 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/di/PlatformManagerModule.kt (+5 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/processor/AuthenticatorBridgeProcessorImpl.kt (+21 -8)
➕ app/src/main/java/com/x8bit/bitwarden/data/platform/util/AddTotpIntentFromAuthenticatorUtils.kt (+41 -0)
📝 app/src/test/java/com/x8bit/bitwarden/MainViewModelTest.kt (+72 -0)
➕ app/src/test/java/com/x8bit/bitwarden/data/auth/manager/AddTotpItemFromAuthenticatorTest.kt (+26 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/processor/AuthenticatorBridgeProcessorTest.kt (+110 -2)
📝 authenticatorbridge/src/main/aidl/com/bitwarden/authenticatorbridge/IAuthenticatorBridgeService.aidl (+3 -8)
📝 authenticatorbridge/src/main/java/com/bitwarden/authenticatorbridge/manager/AuthenticatorBridgeManager.kt (+10 -0)
📝 authenticatorbridge/src/main/java/com/bitwarden/authenticatorbridge/manager/AuthenticatorBridgeManagerImpl.kt (+25 -1)
📝 authenticatorbridge/src/main/java/com/bitwarden/authenticatorbridge/util/EncryptionUtils.kt (+1 -1)

📄 Description

🎟️ Tracking

https://livefront.atlassian.net/browse/BITAU-112
https://livefront.atlassian.net/browse/BITAU-111

Corresponding authenticator PR:
https://github.com/bitwarden/authenticator-android/pull/250

📔 Objective

The goal of this PR is to add logic to the authenticatorbridge SDK for allowing deep linking into the add item flow from the authenticator app.

📸 Screenshots

N/A

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4128 **Author:** [@ahaisting-livefront](https://github.com/ahaisting-livefront) **Created:** 10/21/2024 **Status:** ✅ Merged **Merged:** 10/23/2024 **Merged by:** [@ahaisting-livefront](https://github.com/ahaisting-livefront) **Base:** `main` ← **Head:** `create-add-totp-item-intent` --- ### 📝 Commits (2) - [`b758884`](https://github.com/bitwarden/android/commit/b758884e613673d30efadb0f83f10d395a131e47) BITAU-112 Support deep link into add item flow from Authenticator app - [`e615633`](https://github.com/bitwarden/android/commit/e615633712a3e2f0ff226cf818af2ecc90d4bbea) Update chain formatting ### 📊 Changes **15 files changed** (+365 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `app/libs/authenticatorbridge-0.1.0-SNAPSHOT-release.aar` (+0 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/MainViewModel.kt` (+18 -1) ➕ `app/src/main/java/com/x8bit/bitwarden/data/auth/manager/AddTotpItemFromAuthenticatorManager.kt` (+15 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/auth/manager/AddTotpItemFromAuthenticatorManagerImpl.kt` (+11 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/manager/di/AuthManagerModule.kt` (+7 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/di/PlatformManagerModule.kt` (+5 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/processor/AuthenticatorBridgeProcessorImpl.kt` (+21 -8) ➕ `app/src/main/java/com/x8bit/bitwarden/data/platform/util/AddTotpIntentFromAuthenticatorUtils.kt` (+41 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/MainViewModelTest.kt` (+72 -0) ➕ `app/src/test/java/com/x8bit/bitwarden/data/auth/manager/AddTotpItemFromAuthenticatorTest.kt` (+26 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/processor/AuthenticatorBridgeProcessorTest.kt` (+110 -2) 📝 `authenticatorbridge/src/main/aidl/com/bitwarden/authenticatorbridge/IAuthenticatorBridgeService.aidl` (+3 -8) 📝 `authenticatorbridge/src/main/java/com/bitwarden/authenticatorbridge/manager/AuthenticatorBridgeManager.kt` (+10 -0) 📝 `authenticatorbridge/src/main/java/com/bitwarden/authenticatorbridge/manager/AuthenticatorBridgeManagerImpl.kt` (+25 -1) 📝 `authenticatorbridge/src/main/java/com/bitwarden/authenticatorbridge/util/EncryptionUtils.kt` (+1 -1) </details> ### 📄 Description ## 🎟️ Tracking https://livefront.atlassian.net/browse/BITAU-112 https://livefront.atlassian.net/browse/BITAU-111 Corresponding authenticator PR: https://github.com/bitwarden/authenticator-android/pull/250 ## 📔 Objective The goal of this PR is to add logic to the `authenticatorbridge` SDK for allowing deep linking into the add item flow from the authenticator app. ## 📸 Screenshots N/A ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:48:40 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4707
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?