github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 12:32:53 -05:00
Code Issues 144 Packages Projects Releases 93 Wiki Activity

[PR #4125] [MERGED] PM-11187 show import success bottom sheet after success import sync #4704

New Issue
Closed
opened 2025-11-26 23:48:38 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:48:38 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4125
Author: @dseverns-livefront
Created: 10/21/2024
Status: ✅ Merged
Merged: 10/24/2024
Merged by: @dseverns-livefront

Base: main ← Head: PM-11187-import-success-screen

📝 Commits (5)

  • 73ef457 PM-11187 show import success bottom sheet after success import sync
  • 20e2f42 fix test
  • ef3d302 fix comment
  • ed9d158 Move out to component add tests and other feedback
  • 36b7dc9 feedback

📊 Changes

21 files changed (+701 additions, -131 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/appbar/BitwardenTopAppBar.kt (+4 -2)
➕ app/src/main/java/com/x8bit/bitwarden/ui/platform/components/bottomsheet/BitwardenModalBottomSheet.kt (+79 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/content/BitwardenContentBlock.kt (+19 -15)
➕ app/src/main/java/com/x8bit/bitwarden/ui/platform/components/model/ContentBlockData.kt (+31 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/vaultunlocked/VaultUnlockedNavigation.kt (+0 -4)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/theme/shape/BitwardenShapes.kt (+1 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/theme/shape/Shapes.kt (+1 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/importlogins/ImportLoginsNavigation.kt (+0 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/importlogins/ImportLoginsScreen.kt (+115 -3)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/importlogins/ImportLoginsViewModel.kt (+28 -8)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/importlogins/components/InstructionRowItem.kt (+6 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/importlogins/handlers/ImportLoginHandler.kt (+5 -1)
➕ app/src/main/res/drawable-night/img_secure_devices.xml (+73 -0)
➕ app/src/main/res/drawable/ic_desktop.xml (+10 -0)
➕ app/src/main/res/drawable/ic_puzzle.xml (+10 -0)
➕ app/src/main/res/drawable/ic_shield.xml (+13 -0)
➕ app/src/main/res/drawable/img_secure_devices.xml (+77 -0)
📝 app/src/main/res/values/strings.xml (+10 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/base/BaseComposeTest.kt (+8 -1)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/importlogins/ImportLoginsScreenTest.kt (+122 -73)

...and 1 more files

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-11187

📔 Objective

  • show bottom sheet at the end of the import logins flow if the sync was successful

📸 Screenshots

https://github.com/user-attachments/assets/222cd323-a1c6-46bb-aef0-5940416031dc

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4125 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 10/21/2024 **Status:** ✅ Merged **Merged:** 10/24/2024 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `PM-11187-import-success-screen` --- ### 📝 Commits (5) - [`73ef457`](https://github.com/bitwarden/android/commit/73ef457a3fb6c1276e0d43719b72ba5cc0feb945) PM-11187 show import success bottom sheet after success import sync - [`20e2f42`](https://github.com/bitwarden/android/commit/20e2f4212a6c6fc9ea38914a15f6fea2cdf93ee0) fix test - [`ef3d302`](https://github.com/bitwarden/android/commit/ef3d302624d11267ebbdecba9dec287476bc9d81) fix comment - [`ed9d158`](https://github.com/bitwarden/android/commit/ed9d15895509ffb262b6ce7676086070599156b9) Move out to component add tests and other feedback - [`36b7dc9`](https://github.com/bitwarden/android/commit/36b7dc98339744b376e6601ac69356c88757df0d) feedback ### 📊 Changes **21 files changed** (+701 additions, -131 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/appbar/BitwardenTopAppBar.kt` (+4 -2) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/bottomsheet/BitwardenModalBottomSheet.kt` (+79 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/content/BitwardenContentBlock.kt` (+19 -15) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/model/ContentBlockData.kt` (+31 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/vaultunlocked/VaultUnlockedNavigation.kt` (+0 -4) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/theme/shape/BitwardenShapes.kt` (+1 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/theme/shape/Shapes.kt` (+1 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/importlogins/ImportLoginsNavigation.kt` (+0 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/importlogins/ImportLoginsScreen.kt` (+115 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/importlogins/ImportLoginsViewModel.kt` (+28 -8) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/importlogins/components/InstructionRowItem.kt` (+6 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/importlogins/handlers/ImportLoginHandler.kt` (+5 -1) ➕ `app/src/main/res/drawable-night/img_secure_devices.xml` (+73 -0) ➕ `app/src/main/res/drawable/ic_desktop.xml` (+10 -0) ➕ `app/src/main/res/drawable/ic_puzzle.xml` (+10 -0) ➕ `app/src/main/res/drawable/ic_shield.xml` (+13 -0) ➕ `app/src/main/res/drawable/img_secure_devices.xml` (+77 -0) 📝 `app/src/main/res/values/strings.xml` (+10 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/base/BaseComposeTest.kt` (+8 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/importlogins/ImportLoginsScreenTest.kt` (+122 -73) _...and 1 more files_ </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-11187 <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective - show bottom sheet at the end of the import logins flow if the sync was successful <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots https://github.com/user-attachments/assets/222cd323-a1c6-46bb-aef0-5940416031dc ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:48:38 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4704
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?