github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 11:44:41 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4114] [MERGED] PM-13690: Add dialog before switching account during passwordless login #4695

New Issue
Closed
opened 2025-11-26 23:48:31 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:48:31 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4114
Author: @david-livefront
Created: 10/17/2024
Status: ✅ Merged
Merged: 10/21/2024
Merged by: @david-livefront

Base: main ← Head: PM-13690-switch-account-dialog

📝 Commits (1)

  • 5b809e5 PM-13690: Add dialog before switching account during passwordless login

📊 Changes

6 files changed (+341 additions, -40 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/MainViewModel.kt (+10 -3)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/loginapproval/LoginApprovalScreen.kt (+40 -11)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/loginapproval/LoginApprovalViewModel.kt (+94 -11)
📝 app/src/test/java/com/x8bit/bitwarden/MainViewModelTest.kt (+7 -4)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/loginapproval/LoginApprovalScreenTest.kt (+73 -3)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/loginapproval/LoginApprovalViewModelTest.kt (+117 -8)

📄 Description

🎟️ Tracking

PM-13690

📔 Objective

This PR adds a dialog that appears for users who are logged in when switching to a different account for passwordless login.

📸 Screenshots

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4114 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 10/17/2024 **Status:** ✅ Merged **Merged:** 10/21/2024 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-13690-switch-account-dialog` --- ### 📝 Commits (1) - [`5b809e5`](https://github.com/bitwarden/android/commit/5b809e544a1731d90d88131c06acfe77fbffccec) PM-13690: Add dialog before switching account during passwordless login ### 📊 Changes **6 files changed** (+341 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/MainViewModel.kt` (+10 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/loginapproval/LoginApprovalScreen.kt` (+40 -11) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/loginapproval/LoginApprovalViewModel.kt` (+94 -11) 📝 `app/src/test/java/com/x8bit/bitwarden/MainViewModelTest.kt` (+7 -4) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/loginapproval/LoginApprovalScreenTest.kt` (+73 -3) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/loginapproval/LoginApprovalViewModelTest.kt` (+117 -8) </details> ### 📄 Description ## 🎟️ Tracking [PM-13690](https://bitwarden.atlassian.net/browse/PM-13690) ## 📔 Objective This PR adds a dialog that appears for users who are logged in when switching to a different account for passwordless login. ## 📸 Screenshots <video src="https://github.com/user-attachments/assets/2efb9f48-bf4f-42bc-b3d9-008724c151f5" width="300" /> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-13690]: https://bitwarden.atlassian.net/browse/PM-13690?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:48:31 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4695
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?