github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 11:44:41 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4107] [MERGED] PM-13464 and PM-13627 support #4690

New Issue
Closed
opened 2025-11-26 23:48:27 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:48:27 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4107
Author: @dseverns-livefront
Created: 10/16/2024
Status: ✅ Merged
Merged: 10/17/2024
Merged by: @dseverns-livefront

Base: main ← Head: check-for-empty-vaul-at-datalayer

📝 Commits (2)

  • 87c3103 PM-13464 PM-13627 centralize first time states into one manager to better support these tickets
  • 9791f4a fmt

📊 Changes

45 files changed (+662 additions, -357 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt (+6 -5)
📝 app/src/main/java/com/x8bit/bitwarden/data/auth/repository/di/AuthRepositoryModule.kt (+3 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/auth/repository/model/UserState.kt (+1 -17)
📝 app/src/main/java/com/x8bit/bitwarden/data/auth/repository/util/AuthDiskSourceExtensions.kt (+0 -40)
📝 app/src/main/java/com/x8bit/bitwarden/data/auth/repository/util/UserStateJsonExtensions.kt (+2 -1)
➕ app/src/main/java/com/x8bit/bitwarden/data/platform/manager/FirstTimeActionManager.kt (+47 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/platform/manager/FirstTimeActionManagerImpl.kt (+186 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/di/PlatformManagerModule.kt (+19 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/FirstTimeState.kt (+24 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/repository/SettingsRepository.kt (+0 -18)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/repository/SettingsRepositoryImpl.kt (+0 -61)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/SettingsViewModel.kt (+6 -6)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/vaultunlockednavbar/VaultUnlockedNavBarViewModel.kt (+4 -4)
📝 app/src/test/java/com/x8bit/bitwarden/MainViewModelTest.kt (+2 -1)
📝 app/src/test/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt (+9 -2)
📝 app/src/test/java/com/x8bit/bitwarden/data/auth/repository/util/AuthDiskSourceExtensionsTest.kt (+0 -43)
📝 app/src/test/java/com/x8bit/bitwarden/data/auth/repository/util/UserStateJsonExtensionsTest.kt (+21 -20)
📝 app/src/test/java/com/x8bit/bitwarden/data/autofill/fido2/processor/Fido2ProviderProcessorTest.kt (+2 -1)
➕ app/src/test/java/com/x8bit/bitwarden/data/platform/manager/FirstTimeActionManagerTest.kt (+234 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/repository/SettingsRepositoryTest.kt (+0 -65)

...and 25 more files

📄 Description

🎟️ Tracking

Supports:
#4101 and #4096

📔 Objective

  • centralize data aggregation for determining first time states for showing action cards and badges.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4107 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 10/16/2024 **Status:** ✅ Merged **Merged:** 10/17/2024 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `check-for-empty-vaul-at-datalayer` --- ### 📝 Commits (2) - [`87c3103`](https://github.com/bitwarden/android/commit/87c31030bd9e4ae3d35fcf8af15e2720767d7b0c) PM-13464 PM-13627 centralize first time states into one manager to better support these tickets - [`9791f4a`](https://github.com/bitwarden/android/commit/9791f4ac144224657e9d1c4fadec4ca4b95497d8) fmt ### 📊 Changes **45 files changed** (+662 additions, -357 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt` (+6 -5) 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/di/AuthRepositoryModule.kt` (+3 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/model/UserState.kt` (+1 -17) 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/util/AuthDiskSourceExtensions.kt` (+0 -40) 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/util/UserStateJsonExtensions.kt` (+2 -1) ➕ `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/FirstTimeActionManager.kt` (+47 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/FirstTimeActionManagerImpl.kt` (+186 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/di/PlatformManagerModule.kt` (+19 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/FirstTimeState.kt` (+24 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/repository/SettingsRepository.kt` (+0 -18) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/repository/SettingsRepositoryImpl.kt` (+0 -61) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/SettingsViewModel.kt` (+6 -6) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/vaultunlockednavbar/VaultUnlockedNavBarViewModel.kt` (+4 -4) 📝 `app/src/test/java/com/x8bit/bitwarden/MainViewModelTest.kt` (+2 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt` (+9 -2) 📝 `app/src/test/java/com/x8bit/bitwarden/data/auth/repository/util/AuthDiskSourceExtensionsTest.kt` (+0 -43) 📝 `app/src/test/java/com/x8bit/bitwarden/data/auth/repository/util/UserStateJsonExtensionsTest.kt` (+21 -20) 📝 `app/src/test/java/com/x8bit/bitwarden/data/autofill/fido2/processor/Fido2ProviderProcessorTest.kt` (+2 -1) ➕ `app/src/test/java/com/x8bit/bitwarden/data/platform/manager/FirstTimeActionManagerTest.kt` (+234 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/repository/SettingsRepositoryTest.kt` (+0 -65) _...and 25 more files_ </details> ### 📄 Description ## 🎟️ Tracking Supports: #4101 and #4096 <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective - centralize data aggregation for determining first time states for showing action cards and badges. <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:48:27 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4690
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?