github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 14:16:23 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4099] [MERGED] PM-13382 show contextual message for the level of Biometrics available #4683

New Issue
Closed
opened 2025-11-26 23:48:21 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:48:21 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4099
Author: @dseverns-livefront
Created: 10/15/2024
Status: ✅ Merged
Merged: 10/16/2024
Merged by: @dseverns-livefront

Base: main ← Head: PM-13382-biometrics-toggle

📝 Commits (5)

  • ad3d663 PM-13382 show contextual message for the level of Biometrics available on the device
  • 3ce6043 use existing text place
  • 80b13a7 detekt
  • ce7469e bye column
  • 3974781 optimize and fix kdoc

📊 Changes

8 files changed (+57 additions, -11 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/accountsetup/SetupUnlockScreen.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/toggle/BitwardenUnlockWithBiometricsSwitch.kt (+19 -5)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityScreen.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/biometrics/BiometricsManager.kt (+16 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/biometrics/BiometricsManagerImpl.kt (+14 -1)
📝 app/src/main/res/values/strings.xml (+2 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/accountsetup/SetupUnlockScreenTest.kt (+2 -1)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityScreenTest.kt (+2 -1)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13382

📔 Objective

  • Show a message under the biometric toggle with context to the biometrics available on the users device.
  • A separate message for all devices with Class 3 (strong) and class 2 (weak) authentication.

📸 Screenshots

after1
after2
after3
after4

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4099 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 10/15/2024 **Status:** ✅ Merged **Merged:** 10/16/2024 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `PM-13382-biometrics-toggle` --- ### 📝 Commits (5) - [`ad3d663`](https://github.com/bitwarden/android/commit/ad3d663427f45350bc9a76d9a54f9a70d6d0c11b) PM-13382 show contextual message for the level of Biometrics available on the device - [`3ce6043`](https://github.com/bitwarden/android/commit/3ce6043fd67cf9f657e5f71ca80ae8f49fc347d4) use existing text place - [`80b13a7`](https://github.com/bitwarden/android/commit/80b13a7367a797ccf7d1c4dca8317fbb7f898864) detekt - [`ce7469e`](https://github.com/bitwarden/android/commit/ce7469e0bebd3ffffb118e4e869ce5838391875b) bye column - [`3974781`](https://github.com/bitwarden/android/commit/397478169529776d813abcd557aefc0e089e0391) optimize and fix kdoc ### 📊 Changes **8 files changed** (+57 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/accountsetup/SetupUnlockScreen.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/toggle/BitwardenUnlockWithBiometricsSwitch.kt` (+19 -5) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityScreen.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/biometrics/BiometricsManager.kt` (+16 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/biometrics/BiometricsManagerImpl.kt` (+14 -1) 📝 `app/src/main/res/values/strings.xml` (+2 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/accountsetup/SetupUnlockScreenTest.kt` (+2 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/accountsecurity/AccountSecurityScreenTest.kt` (+2 -1) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-13382 <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective - Show a message under the biometric toggle with context to the biometrics available on the users device. - A separate message for all devices with Class 3 (strong) and class 2 (weak) authentication. <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots ![after1](https://github.com/user-attachments/assets/b96bcaf6-47d7-4e8e-bc19-1b168840d625) ![after2](https://github.com/user-attachments/assets/c1ea00e2-8f02-430a-bb1d-8087abddefed) ![after3](https://github.com/user-attachments/assets/60037f1c-8603-4492-8a81-437ee967bd4b) ![after4](https://github.com/user-attachments/assets/40a12bab-7de9-4bcb-8674-8ab8345d070f) <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:48:21 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4683
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?