github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 11:44:41 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4097] [MERGED] Remove launch icon and update BitwardenActionCard #4681

New Issue
Closed
opened 2025-11-26 23:48:19 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:48:19 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4097
Author: @david-livefront
Created: 10/15/2024
Status: ✅ Merged
Merged: 10/15/2024
Merged by: @david-livefront

Base: main ← Head: more-icon-updates

📝 Commits (1)

  • e17bc8c Remove launch icon and update BitwardenActionCard

📊 Changes

3 files changed (+29 additions, -40 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/card/BitwardenActionCard.kt (+28 -27)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemLoginContent.kt (+1 -1)
➖ app/src/main/res/drawable/ic_launch.xml (+0 -12)

📄 Description

🎟️ Tracking

N/A

📔 Objective

This PR removes the ic_launch icon and replaces it with the ic_external_link icon.

Additionally, the BitwardenActionCard has been updated to better match designs.

📸 Screenshots

Before After

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4097 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 10/15/2024 **Status:** ✅ Merged **Merged:** 10/15/2024 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `more-icon-updates` --- ### 📝 Commits (1) - [`e17bc8c`](https://github.com/bitwarden/android/commit/e17bc8c0a033dd39927b168f0fe5082697f46cd5) Remove launch icon and update BitwardenActionCard ### 📊 Changes **3 files changed** (+29 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/card/BitwardenActionCard.kt` (+28 -27) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/item/VaultItemLoginContent.kt` (+1 -1) ➖ `app/src/main/res/drawable/ic_launch.xml` (+0 -12) </details> ### 📄 Description ## 🎟️ Tracking N/A ## 📔 Objective This PR removes the `ic_launch` icon and replaces it with the `ic_external_link` icon. Additionally, the `BitwardenActionCard` has been updated to better match designs. ## 📸 Screenshots | Before | After | | --- | --- | | <img src="https://github.com/user-attachments/assets/035e1aae-a145-4344-91c1-fa1e76bc2acb" width="300" /> | <img src="https://github.com/user-attachments/assets/b59cfb99-eb02-4b6e-8fd0-1585127204a8" width="300" /> | | <img src="https://github.com/user-attachments/assets/7870404f-907f-4bd8-a73c-f423318fae1c" width="300" /> | <img src="https://github.com/user-attachments/assets/0c56ee6f-5b6a-40c8-80fb-b049d69ac115" width="300" /> | ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:48:19 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4681
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?