[PR #4092] [MERGED] PM-13648 Nav to new create account when email verification is on #4677

New Issue

2025-11-26T23:48:16-06:00

GiteaMirror commented

2025-11-26 23:48:16 -06:00

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4092
Author: @dseverns-livefront
Created: 10/14/2024
Status: ✅ Merged
Merged: 10/16/2024
Merged by: @dseverns-livefront

Base: main ← Head: carousel-create-account-nav

📝 Commits (1)

46a2cc5 PM-13648 Nav to new create account when email verification is on

📊 Changes

6 files changed (+61 additions, -9 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/auth/AuthNavigation.kt (+1 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeNavigation.kt (+2 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeScreen.kt (+2 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeViewModel.kt (+16 -2)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeScreenTest.kt (+8 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeViewModelTest.kt (+32 -7)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13648

📔 Objective

When the email verification flag is enabled we want to go to the new create account flow, this was not happening from the welcome carousel screen.

📸 Screenshots

https://github.com/user-attachments/assets/3433a577-fd17-4191-af5d-68fcba769a95

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4092 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 10/14/2024 **Status:** ✅ Merged **Merged:** 10/16/2024 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `carousel-create-account-nav` --- ### 📝 Commits (1) - [`46a2cc5`](https://github.com/bitwarden/android/commit/46a2cc51e644fa5d7cee5c239f71c23f8e2e5255) PM-13648 Nav to new create account when email verification is on ### 📊 Changes **6 files changed** (+61 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/auth/AuthNavigation.kt` (+1 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeNavigation.kt` (+2 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeScreen.kt` (+2 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeViewModel.kt` (+16 -2) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeScreenTest.kt` (+8 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/welcome/WelcomeViewModelTest.kt` (+32 -7) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-13648  ## 📔 Objective - When the email verification flag is enabled we want to go to the new create account flow, this was not happening from the welcome carousel screen.  ## 📸 Screenshots https://github.com/user-attachments/assets/3433a577-fd17-4191-af5d-68fcba769a95  ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines  - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-26 23:48:16 -06:00

GiteaMirror closed this issue