github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 13:44:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4087] [MERGED] PM-13635, PM-13636, PM-13637: Update icons #4672

New Issue
Closed
opened 2025-11-26 23:48:12 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:48:12 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4087
Author: @david-livefront
Created: 10/14/2024
Status: ✅ Merged
Merged: 10/14/2024
Merged by: @david-livefront

Base: main ← Head: PM-13635-PM-13636-PM-13637-update-icons

📝 Commits (1)

  • acc2f0e PM-13635, PM-13636, PM-13637: Update icons

📊 Changes

58 files changed (+263 additions, -273 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/accountsetup/SetupCompleteScreen.kt (+3 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordgenerator/MasterPasswordGeneratorScreen.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordguidance/MasterPasswordGuidanceScreen.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/account/BitwardenAccountSwitcher.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/appbar/BitwardenSearchTopAppBar.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/card/BitwardenActionCard.kt (+2 -3)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/card/BitwardenActionCardSmall.kt (+2 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/dialog/BitwardenDateSelectButton.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/dialog/BitwardenTimeSelectButton.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/dropdown/BitwardenMultiSelectButton.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/dropdown/EnvironmentSelector.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/field/BitwardenTextFieldWithActions.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/search/SearchEmptyContent.kt (+0 -16)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/blockautofill/BlockAutoFillScreen.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/folders/FoldersScreen.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/SendEmpty.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/SendScreen.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/addsend/AddSendContent.kt (+2 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditCustomField.kt (+4 -4)

...and 38 more files

📄 Description

🎟️ Tracking

PM-13635
PM-13636
PM-13637

📔 Objective

This PR updates icons in the app based on a design audit.

📸 Screenshots

Before After

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4087 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 10/14/2024 **Status:** ✅ Merged **Merged:** 10/14/2024 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-13635-PM-13636-PM-13637-update-icons` --- ### 📝 Commits (1) - [`acc2f0e`](https://github.com/bitwarden/android/commit/acc2f0ec8afdb3d2c865aae40eab47133bb38239) PM-13635, PM-13636, PM-13637: Update icons ### 📊 Changes **58 files changed** (+263 additions, -273 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/accountsetup/SetupCompleteScreen.kt` (+3 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordgenerator/MasterPasswordGeneratorScreen.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordguidance/MasterPasswordGuidanceScreen.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/account/BitwardenAccountSwitcher.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/appbar/BitwardenSearchTopAppBar.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/card/BitwardenActionCard.kt` (+2 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/card/BitwardenActionCardSmall.kt` (+2 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/dialog/BitwardenDateSelectButton.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/dialog/BitwardenTimeSelectButton.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/dropdown/BitwardenMultiSelectButton.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/dropdown/EnvironmentSelector.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/field/BitwardenTextFieldWithActions.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/search/SearchEmptyContent.kt` (+0 -16) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/blockautofill/BlockAutoFillScreen.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/folders/FoldersScreen.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/SendEmpty.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/SendScreen.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/send/addsend/AddSendContent.kt` (+2 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditCustomField.kt` (+4 -4) _...and 38 more files_ </details> ### 📄 Description ## 🎟️ Tracking [PM-13635](https://bitwarden.atlassian.net/browse/PM-13635) [PM-13636](https://bitwarden.atlassian.net/browse/PM-13636) [PM-13637](https://bitwarden.atlassian.net/browse/PM-13637) ## 📔 Objective This PR updates icons in the app based on a design audit. ## 📸 Screenshots | Before | After | | --- | --- | | <img src="https://github.com/user-attachments/assets/5a72cdc8-c1a3-463d-ac0c-69d668d208f0" width="300" /> | <img src="https://github.com/user-attachments/assets/2c6ef78d-bad1-4631-bcdd-b06501683bc2" width="300" /> | | <img src="https://github.com/user-attachments/assets/3c1d395f-31db-48cb-88ef-561fca3a8d18" width="300" /> | <img src="https://github.com/user-attachments/assets/f74f9762-09fa-456c-bb82-8cf76c09443e" width="300" /> | | <img src="https://github.com/user-attachments/assets/b4dd5d96-5333-4920-b56d-de6cebdeb8b8" width="300" /> | <img src="https://github.com/user-attachments/assets/2e0b958d-4616-4fad-a3bf-a3e4548e2855" width="300" /> | | <img src="https://github.com/user-attachments/assets/8fa784a7-dc9c-4801-9c3e-d3072c0bb1ef" width="300" /> | <img src="https://github.com/user-attachments/assets/d7a165c1-2a05-404a-8ccc-b642c2aa2bdd" width="300" /> | ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-13635]: https://bitwarden.atlassian.net/browse/PM-13635?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-13636]: https://bitwarden.atlassian.net/browse/PM-13636?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-13637]: https://bitwarden.atlassian.net/browse/PM-13637?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:48:12 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4672
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?