[PR #4076] [MERGED] PM-13471 Remove instances deprecated ClickableText #4667

New Issue

2025-11-26T23:48:09-06:00

GiteaMirror commented

2025-11-26 23:48:09 -06:00

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4076
Author: @dseverns-livefront
Created: 10/11/2024
Status: ✅ Merged
Merged: 10/14/2024
Merged by: @dseverns-livefront

Base: main ← Head: fix-click-warnings

📝 Commits (3)

1666b9e Remove instances deprecated ClickableText
136a41e remove space
0406a97 fix tests

📊 Changes

6 files changed (+325 additions, -137 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/checkemail/CheckEmailScreen.kt (+18 -42)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationScreen.kt (+25 -79)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/base/util/Text.kt (+89 -6)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/checkemail/CheckEmailScreenTest.kt (+24 -10)
➕ app/src/test/java/com/x8bit/bitwarden/ui/platform/base/util/ClickableAnnotatedStringTest.kt (+136 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/util/ComposeTestHelpers.kt (+33 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13471

📔 Objective

ClickableText is deprecated, moving to using LinkAnnotation with the Text function.
create a helper method to create clickable spans with default highlighting.
Will be used further to implement design for https://bitwarden.atlassian.net/browse/PM-11182

📸 Screenshots

Tested and verified with existing links.

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4076 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 10/11/2024 **Status:** ✅ Merged **Merged:** 10/14/2024 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `fix-click-warnings` --- ### 📝 Commits (3) - [`1666b9e`](https://github.com/bitwarden/android/commit/1666b9ef2edb2141cf860cc155d59a227817dcc7) Remove instances deprecated ClickableText - [`136a41e`](https://github.com/bitwarden/android/commit/136a41e7cb728a2fd028ef5d2e2b29d1bddaca5b) remove space - [`0406a97`](https://github.com/bitwarden/android/commit/0406a9788435bf8e220f78bedd17ead723380550) fix tests ### 📊 Changes **6 files changed** (+325 additions, -137 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/checkemail/CheckEmailScreen.kt` (+18 -42) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/startregistration/StartRegistrationScreen.kt` (+25 -79) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/base/util/Text.kt` (+89 -6) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/checkemail/CheckEmailScreenTest.kt` (+24 -10) ➕ `app/src/test/java/com/x8bit/bitwarden/ui/platform/base/util/ClickableAnnotatedStringTest.kt` (+136 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/util/ComposeTestHelpers.kt` (+33 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-13471  ## 📔 Objective - `ClickableText` is deprecated, moving to using `LinkAnnotation` with the `Text` function. - create a helper method to create clickable spans with default highlighting. - Will be used further to implement design for https://bitwarden.atlassian.net/browse/PM-11182  ## 📸 Screenshots Tested and verified with existing links.  ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines  - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-26 23:48:09 -06:00

GiteaMirror closed this issue