github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 13:44:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #4066] [MERGED] [PM-11982] On Passwordless flow switch activeAccount to match PasswordlessRequest userId #4658

New Issue
Closed
opened 2025-11-26 23:48:01 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:48:01 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4066
Author: @aj-rosado
Created: 10/10/2024
Status: ✅ Merged
Merged: 10/14/2024
Merged by: @aj-rosado

Base: main ← Head: PM-11982/broken-login-request-inactive-account

📝 Commits (2)

  • 5b1985e if activeAccount doesn't match the request userId calls switchAccount
  • 7f426b8 Merge branch 'main' into PM-11982/broken-login-request-inactive-account

📊 Changes

2 files changed (+38 additions, -3 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/MainViewModel.kt (+4 -1)
📝 app/src/test/java/com/x8bit/bitwarden/MainViewModelTest.kt (+34 -2)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-11982

📔 Objective

On a passwordless request for an inactive account, the flow is not verifying if the currentUser matches the PasswordlessRequestData.userId. When this ids don't match we should switch the current user.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4066 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 10/10/2024 **Status:** ✅ Merged **Merged:** 10/14/2024 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `main` ← **Head:** `PM-11982/broken-login-request-inactive-account` --- ### 📝 Commits (2) - [`5b1985e`](https://github.com/bitwarden/android/commit/5b1985ef822741394c5562f695f864a7d09e0e96) if activeAccount doesn't match the request userId calls switchAccount - [`7f426b8`](https://github.com/bitwarden/android/commit/7f426b8694ce76e6c93384655bae62230bd4ff8e) Merge branch 'main' into PM-11982/broken-login-request-inactive-account ### 📊 Changes **2 files changed** (+38 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/MainViewModel.kt` (+4 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/MainViewModelTest.kt` (+34 -2) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-11982 ## 📔 Objective On a passwordless request for an inactive account, the flow is not verifying if the `currentUser` matches the `PasswordlessRequestData.userId`. When this ids don't match we should switch the current user. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:48:01 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4658
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?