[PR #4063] [MERGED] BITAU-105 Add support for deep link to account security #4655

Closed
opened 2025-11-26 23:47:58 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4063
Author: @ahaisting-livefront
Created: 10/10/2024
Status: Merged
Merged: 10/16/2024
Merged by: @david-livefront

Base: mainHead: settings-deep-link


📝 Commits (1)

  • 4df6ed7 BITAU-105 Add support for deep link to account security

📊 Changes

15 files changed (+243 additions, -9 deletions)

View changed files

📝 app/src/main/AndroidManifest.xml (+5 -0)
📝 app/src/main/java/com/x8bit/bitwarden/MainViewModel.kt (+7 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/SpecialCircumstance.kt (+6 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavViewModel.kt (+1 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/SettingsScreen.kt (+1 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/SettingsViewModel.kt (+18 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/vaultunlockednavbar/VaultUnlockedNavBarScreen.kt (+5 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/vaultunlockednavbar/VaultUnlockedNavBarViewModel.kt (+11 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/util/ShortcutUtils.kt (+6 -0)
📝 app/src/test/java/com/x8bit/bitwarden/MainViewModelTest.kt (+53 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavViewModelTest.kt (+38 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/SettingsScreenTest.kt (+19 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/SettingsViewModelTest.kt (+37 -8)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/vaultunlockednavbar/VaultUnlockedNavBarScreenTest.kt (+15 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/vaultunlockednavbar/VaultUnlockedNavBarViewModelTest.kt (+21 -0)

📄 Description

🎟️ Tracking

https://livefront.atlassian.net/browse/BITAU-105

📔 Objective

The goal of this PR is to add a deep link to account security settings that will be used by the Authenticator app.

📸 Screenshots

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4063 **Author:** [@ahaisting-livefront](https://github.com/ahaisting-livefront) **Created:** 10/10/2024 **Status:** ✅ Merged **Merged:** 10/16/2024 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `settings-deep-link` --- ### 📝 Commits (1) - [`4df6ed7`](https://github.com/bitwarden/android/commit/4df6ed75584127f4a24f6cda7669d609de597ef2) BITAU-105 Add support for deep link to account security ### 📊 Changes **15 files changed** (+243 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/AndroidManifest.xml` (+5 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/MainViewModel.kt` (+7 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/model/SpecialCircumstance.kt` (+6 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavViewModel.kt` (+1 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/SettingsScreen.kt` (+1 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/SettingsViewModel.kt` (+18 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/vaultunlockednavbar/VaultUnlockedNavBarScreen.kt` (+5 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/vaultunlockednavbar/VaultUnlockedNavBarViewModel.kt` (+11 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/util/ShortcutUtils.kt` (+6 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/MainViewModelTest.kt` (+53 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/rootnav/RootNavViewModelTest.kt` (+38 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/SettingsScreenTest.kt` (+19 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/settings/SettingsViewModelTest.kt` (+37 -8) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/vaultunlockednavbar/VaultUnlockedNavBarScreenTest.kt` (+15 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/feature/vaultunlockednavbar/VaultUnlockedNavBarViewModelTest.kt` (+21 -0) </details> ### 📄 Description ## 🎟️ Tracking https://livefront.atlassian.net/browse/BITAU-105 ## 📔 Objective The goal of this PR is to add a deep link to account security settings that will be used by the Authenticator app. ## 📸 Screenshots <video src="https://github.com/user-attachments/assets/660b6d3a-f9b1-4d62-b111-902919ff1804" width="300" /> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:47:58 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4655