github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-10 00:28:29 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #4060] [MERGED] PM-12668: Update TopAppBar divider #46255

New Issue
Closed
opened 2026-04-26 13:29:28 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 13:29:28 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/4060
Author: @david-livefront
Created: 10/9/2024
Status: ✅ Merged
Merged: 10/10/2024
Merged by: @david-livefront

Base: main ← Head: PM-12668-update-top-app-bar-divider

📝 Commits (1)

  • 018277a PM-12668: Update TopAppBar divider

📊 Changes

9 files changed (+121 additions, -14 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/base/util/ModifierExtensions.kt (+20 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/base/util/TopAppBarScrollBehaviorExtensions.kt (+20 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/appbar/BitwardenMediumTopAppBar.kt (+18 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/appbar/BitwardenSearchTopAppBar.kt (+5 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/appbar/BitwardenTopAppBar.kt (+9 -4)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/search/SearchScreen.kt (+1 -4)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultFilter.kt (+3 -3)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreen.kt (+1 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/base/util/TopAppBarScrollBehaviorExtensionsTest.kt (+44 -0)

📄 Description

🎟️ Tracking

PM-12668

📔 Objective

This PR adds the divider to the bottom of the TopAppBar everywhere in the app.

📸 Screenshots

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/4060 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 10/9/2024 **Status:** ✅ Merged **Merged:** 10/10/2024 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-12668-update-top-app-bar-divider` --- ### 📝 Commits (1) - [`018277a`](https://github.com/bitwarden/android/commit/018277ab3b1720a0b5fd73bb699a1b5dccbde893) PM-12668: Update TopAppBar divider ### 📊 Changes **9 files changed** (+121 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/base/util/ModifierExtensions.kt` (+20 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/base/util/TopAppBarScrollBehaviorExtensions.kt` (+20 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/appbar/BitwardenMediumTopAppBar.kt` (+18 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/appbar/BitwardenSearchTopAppBar.kt` (+5 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/appbar/BitwardenTopAppBar.kt` (+9 -4) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/search/SearchScreen.kt` (+1 -4) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultFilter.kt` (+3 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreen.kt` (+1 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/base/util/TopAppBarScrollBehaviorExtensionsTest.kt` (+44 -0) </details> ### 📄 Description ## 🎟️ Tracking [PM-12668](https://bitwarden.atlassian.net/browse/PM-12668) ## 📔 Objective This PR adds the divider to the bottom of the TopAppBar everywhere in the app. ## 📸 Screenshots <video src="https://github.com/user-attachments/assets/f4dc7024-68a4-41ab-8ece-b3b79032c800" width="300" /> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-12668]: https://bitwarden.atlassian.net/browse/PM-12668?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 13:29:28 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#46255
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?