github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 14:16:23 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3994] [MERGED] [PM-12739] Updated generator maximum number and specials #4593

New Issue
Closed
opened 2025-11-26 23:47:01 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:47:01 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3994
Author: @aj-rosado
Created: 9/30/2024
Status: ✅ Merged
Merged: 9/30/2024
Merged by: @aj-rosado

Base: main ← Head: PM-12739/generator-policy-min-val-config-crash

📝 Commits (3)

  • 3b026c1 Updated maximum number and specials to match other clients and server
  • 6c67683 fixed tests
  • 00444c5 reverted GeneratorViewModelTest and GeneratorScreenTest to not use PASSWORD_COUNTER_MAX value

📊 Changes

4 files changed (+69 additions, -12 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt (+3 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModel.kt (+1 -1)
📝 app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreenTest.kt (+61 -4)
📝 app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModelTest.kt (+4 -5)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12739

📔 Objective

Updated maximum number and specials to match other clients and server
If minimum value is higher than maximum, set it as new maximum in order to avoid the app to crash in a scenario minimum is higher than maximum
Added tests

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3994 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 9/30/2024 **Status:** ✅ Merged **Merged:** 9/30/2024 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `main` ← **Head:** `PM-12739/generator-policy-min-val-config-crash` --- ### 📝 Commits (3) - [`3b026c1`](https://github.com/bitwarden/android/commit/3b026c1c0764f2d295f740514fb60fcf80113e0a) Updated maximum number and specials to match other clients and server - [`6c67683`](https://github.com/bitwarden/android/commit/6c67683a902ab79bdd8b9308f1c3447e5ea755b2) fixed tests - [`00444c5`](https://github.com/bitwarden/android/commit/00444c5655db4dd3d50a18053b947dab68f32029) reverted GeneratorViewModelTest and GeneratorScreenTest to not use PASSWORD_COUNTER_MAX value ### 📊 Changes **4 files changed** (+69 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt` (+3 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModel.kt` (+1 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreenTest.kt` (+61 -4) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModelTest.kt` (+4 -5) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-12739 ## 📔 Objective Updated maximum number and specials to match [other clients](https://github.com/bitwarden/clients/blob/main/libs/tools/generator/core/src/data/default-password-boundaries.ts) and server If minimum value is higher than maximum, set it as new maximum in order to avoid the app to crash in a scenario minimum is higher than maximum Added tests ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:47:01 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4593
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?