github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 11:44:41 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3987] [MERGED] BITAU-97 Add AuthenticatorBridgeManager #4586

New Issue
Closed
opened 2025-11-26 23:46:56 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:46:56 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3987
Author: @ahaisting-livefront
Created: 9/27/2024
Status: ✅ Merged
Merged: 10/1/2024
Merged by: @ahaisting-livefront

Base: main ← Head: bridge-coroutines-wrapper

📝 Commits (10+)

  • f3fc65b BITAU-97 Add AuthenticatorBridgeManager to wrap AuthenticatorBridgeService APIs
  • 067fda1 Add doc for SymmetricKeyStorageProvider
  • c9fc5fb Remove AuthenticatorBridgeSafeyWrapper in favor of an extension function
  • 8cedcad Clean up chaining in onAccountsSync call
  • ea3136e Fix odd formatting
  • 8bc5931 Move AuthenticatorBridgeConnectionType extension to its own package and file
  • 234e8e5 Pull service connection listener into smaller helper functions for organization sake
  • f9b1f1f Remove full jira link
  • 9d789e6 Remove DefaultLifecycleObserver
  • 9f8aed6 Add early return when sync is not enabled

📊 Changes

20 files changed (+965 additions, -0 deletions)

View changed files

📝 app/libs/authenticatorbridge-0.1.0-SNAPSHOT-release.aar (+0 -0)
➕ app/libs/bridge-0.1.0-SNAPSHOT-release.aar (+0 -0)
📝 authenticatorbridge/README.md (+15 -0)
📝 authenticatorbridge/build.gradle.kts (+3 -0)
➕ authenticatorbridge/src/main/java/com/bitwarden/authenticatorbridge/factory/AuthenticatorBridgeFactory.kt (+33 -0)
➕ authenticatorbridge/src/main/java/com/bitwarden/authenticatorbridge/manager/AuthenticatorBridgeManager.kt (+17 -0)
➕ authenticatorbridge/src/main/java/com/bitwarden/authenticatorbridge/manager/AuthenticatorBridgeManagerImpl.kt (+229 -0)
➕ authenticatorbridge/src/main/java/com/bitwarden/authenticatorbridge/manager/model/AccountSyncState.kt (+34 -0)
➕ authenticatorbridge/src/main/java/com/bitwarden/authenticatorbridge/manager/model/AuthenticatorBridgeConnectionType.kt (+19 -0)
➕ authenticatorbridge/src/main/java/com/bitwarden/authenticatorbridge/manager/util/AuthenticatorBridgeConnectionTypeExtensions.kt (+12 -0)
➕ authenticatorbridge/src/main/java/com/bitwarden/authenticatorbridge/provider/AuthenticatorBridgeCallbackProvider.kt (+21 -0)
➕ authenticatorbridge/src/main/java/com/bitwarden/authenticatorbridge/provider/StubAuthenticatorBridgeCallbackProvider.kt (+18 -0)
➕ authenticatorbridge/src/main/java/com/bitwarden/authenticatorbridge/provider/SymmetricKeyStorageProvider.kt (+14 -0)
➕ authenticatorbridge/src/test/java/com/bitwarden/authenticatorbridge/manager/AuthenticatorBridgeManagerTest.kt (+440 -0)
➕ authenticatorbridge/src/test/java/com/bitwarden/authenticatorbridge/manager/util/AuthenticatorBridgeConnectionTypeExtensionsTest.kt (+24 -0)
➕ authenticatorbridge/src/test/java/com/bitwarden/authenticatorbridge/util/FakeLifecycle.kt (+45 -0)
➕ authenticatorbridge/src/test/java/com/bitwarden/authenticatorbridge/util/FakeLifecycleOwner.kt (+10 -0)
➕ authenticatorbridge/src/test/java/com/bitwarden/authenticatorbridge/util/FakeSymmetricKeyStorageProvider.kt (+11 -0)
➕ authenticatorbridge/src/test/java/com/bitwarden/authenticatorbridge/util/TestAuthenticatorBridgeCallbackProvider.kt (+19 -0)
📝 gradle/libs.versions.toml (+1 -0)

📄 Description

🎟️ Tracking

https://livefront.atlassian.net/browse/BITAU-97

📔 Objective

The goal here is to write a wrapper layer to make it easy for consuming applications (the Bitwarden Authenticator app) to connect to AuthenticatorBridgeService.

📸 Screenshots

N/A

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3987 **Author:** [@ahaisting-livefront](https://github.com/ahaisting-livefront) **Created:** 9/27/2024 **Status:** ✅ Merged **Merged:** 10/1/2024 **Merged by:** [@ahaisting-livefront](https://github.com/ahaisting-livefront) **Base:** `main` ← **Head:** `bridge-coroutines-wrapper` --- ### 📝 Commits (10+) - [`f3fc65b`](https://github.com/bitwarden/android/commit/f3fc65bc491e7f09c856607455f450ed1b65288c) BITAU-97 Add AuthenticatorBridgeManager to wrap AuthenticatorBridgeService APIs - [`067fda1`](https://github.com/bitwarden/android/commit/067fda133c5d96370a4cec544f168986e4cf765f) Add doc for SymmetricKeyStorageProvider - [`c9fc5fb`](https://github.com/bitwarden/android/commit/c9fc5fb03ecc328e680d4dd05ae30e729248dc3f) Remove AuthenticatorBridgeSafeyWrapper in favor of an extension function - [`8cedcad`](https://github.com/bitwarden/android/commit/8cedcad269fea09c211be12f3483a354920663bd) Clean up chaining in onAccountsSync call - [`ea3136e`](https://github.com/bitwarden/android/commit/ea3136ece6068642e567d7bfc25ea88ab23f6ebf) Fix odd formatting - [`8bc5931`](https://github.com/bitwarden/android/commit/8bc5931bf0b84b281c0c85a0c2ba07376c2d634e) Move AuthenticatorBridgeConnectionType extension to its own package and file - [`234e8e5`](https://github.com/bitwarden/android/commit/234e8e52db42f4817a1c32baeafa6a68b8f3bc7c) Pull service connection listener into smaller helper functions for organization sake - [`f9b1f1f`](https://github.com/bitwarden/android/commit/f9b1f1f20335521f3124cc4e2f9adc704da1e1f7) Remove full jira link - [`9d789e6`](https://github.com/bitwarden/android/commit/9d789e6a4fbe204d334da38e06aa57a1baa911d1) Remove DefaultLifecycleObserver - [`9f8aed6`](https://github.com/bitwarden/android/commit/9f8aed67773b46ed30400943194f9f3cab0a9c81) Add early return when sync is not enabled ### 📊 Changes **20 files changed** (+965 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `app/libs/authenticatorbridge-0.1.0-SNAPSHOT-release.aar` (+0 -0) ➕ `app/libs/bridge-0.1.0-SNAPSHOT-release.aar` (+0 -0) 📝 `authenticatorbridge/README.md` (+15 -0) 📝 `authenticatorbridge/build.gradle.kts` (+3 -0) ➕ `authenticatorbridge/src/main/java/com/bitwarden/authenticatorbridge/factory/AuthenticatorBridgeFactory.kt` (+33 -0) ➕ `authenticatorbridge/src/main/java/com/bitwarden/authenticatorbridge/manager/AuthenticatorBridgeManager.kt` (+17 -0) ➕ `authenticatorbridge/src/main/java/com/bitwarden/authenticatorbridge/manager/AuthenticatorBridgeManagerImpl.kt` (+229 -0) ➕ `authenticatorbridge/src/main/java/com/bitwarden/authenticatorbridge/manager/model/AccountSyncState.kt` (+34 -0) ➕ `authenticatorbridge/src/main/java/com/bitwarden/authenticatorbridge/manager/model/AuthenticatorBridgeConnectionType.kt` (+19 -0) ➕ `authenticatorbridge/src/main/java/com/bitwarden/authenticatorbridge/manager/util/AuthenticatorBridgeConnectionTypeExtensions.kt` (+12 -0) ➕ `authenticatorbridge/src/main/java/com/bitwarden/authenticatorbridge/provider/AuthenticatorBridgeCallbackProvider.kt` (+21 -0) ➕ `authenticatorbridge/src/main/java/com/bitwarden/authenticatorbridge/provider/StubAuthenticatorBridgeCallbackProvider.kt` (+18 -0) ➕ `authenticatorbridge/src/main/java/com/bitwarden/authenticatorbridge/provider/SymmetricKeyStorageProvider.kt` (+14 -0) ➕ `authenticatorbridge/src/test/java/com/bitwarden/authenticatorbridge/manager/AuthenticatorBridgeManagerTest.kt` (+440 -0) ➕ `authenticatorbridge/src/test/java/com/bitwarden/authenticatorbridge/manager/util/AuthenticatorBridgeConnectionTypeExtensionsTest.kt` (+24 -0) ➕ `authenticatorbridge/src/test/java/com/bitwarden/authenticatorbridge/util/FakeLifecycle.kt` (+45 -0) ➕ `authenticatorbridge/src/test/java/com/bitwarden/authenticatorbridge/util/FakeLifecycleOwner.kt` (+10 -0) ➕ `authenticatorbridge/src/test/java/com/bitwarden/authenticatorbridge/util/FakeSymmetricKeyStorageProvider.kt` (+11 -0) ➕ `authenticatorbridge/src/test/java/com/bitwarden/authenticatorbridge/util/TestAuthenticatorBridgeCallbackProvider.kt` (+19 -0) 📝 `gradle/libs.versions.toml` (+1 -0) </details> ### 📄 Description ## 🎟️ Tracking https://livefront.atlassian.net/browse/BITAU-97 ## 📔 Objective The goal here is to write a wrapper layer to make it easy for consuming applications (the Bitwarden Authenticator app) to connect to AuthenticatorBridgeService. ## 📸 Screenshots N/A ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:46:56 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4586
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?