github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 21:10:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #3173] [MERGED] [PM-5894] Implement Passkey Providers #45673

New Issue
Closed
opened 2026-04-26 12:57:35 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 12:57:35 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3173
Author: @fedemkr
Created: 4/19/2024
Status: ✅ Merged
Merged: 4/25/2024
Merged by: @vvolkgang

Base: main ← Head: feature/maui-migration-passkeys

📝 Commits (10+)

  • 27306fe PM-3349 PM-3350 Added the partial MAUI Community Toolkit implementation for TouchEffect. This is a temporary solution until they finalize this and add it to their nuget package.
  • e0a3c30 PM-3349 PM-3350 Changed SendViewCell and its binding to be directly against the ViewModel
  • 5712639 Merge branch 'feature/maui-migration' of https://github.com/bitwarden/mobile into feature/maui-migration
  • 5f12bb9 PM-3350 Fixed iOS Share extension lazy views loading and an issue with the avatar loading. Also discovered issue with TapGestureRecognizer not working on MAUI Embedding
  • df4d89c PM-3350 Fixed iOS Extensions navigation to several pages and improved avoiding duplicate calls to OnNavigatedTo
  • beda4e9 PM-3350 Updated PCL Crypto to latest alpha version to fix "Dll not found NCrypt" issue
  • f02b341 PM-3350 Removed workaround for iOS issue with Avatar icon as it's now fixed in latest .Net8 release.
  • 2c7870d PM-3349 PM-3350 Removed AsyncCommand "wrapper" and added AsyncRelayCommand directly in all ViewModels that were using the other one.
  • eceb506 Merge branch 'master' into feature/maui-migration
  • 3795f3a PM-3350 Added watchOS app to main project and fixed some csproj conditions for runtime identifiers on iOS.

📊 Changes

200 files changed (+10643 additions, -624 deletions)

View changed files

📝 .gitignore (+1 -0)
➕ lib/android/Xamarin.AndroidX.Credentials/Xamarin.AndroidX.Credentials.1.0.0.nupkg (+0 -0)
➕ lib/android/Xamarin.AndroidX.Credentials/net8.0-android/Xamarin.AndroidX.Credentials.dll (+0 -0)
➕ lib/android/Xamarin.AndroidX.Credentials/net8.0-android/Xamarin.AndroidX.Credentials.xml (+8 -0)
➕ lib/android/Xamarin.AndroidX.Credentials/net8.0-android/credentials-1.2.0.aar (+0 -0)
📝 nuget.config (+1 -0)
📝 src/App/App.csproj (+8 -0)
➕ src/App/Platforms/Android/Autofill/CredentialHelpers.cs (+303 -0)
➕ src/App/Platforms/Android/Autofill/CredentialProviderSelectionActivity.cs (+172 -0)
➕ src/App/Platforms/Android/Autofill/CredentialProviderService.cs (+168 -0)
➕ src/App/Platforms/Android/Autofill/Fido2GetAssertionUserInterface.cs (+77 -0)
➕ src/App/Platforms/Android/Autofill/Fido2MakeCredentialUserInterface.cs (+202 -0)
📝 src/App/Platforms/Android/MainActivity.cs (+11 -0)
📝 src/App/Platforms/Android/MainApplication.cs (+54 -2)
➕ src/App/Platforms/Android/Resources/xml/provider.xml (+6 -0)
📝 src/App/Platforms/Android/Services/AutofillHandler.cs (+50 -4)
📝 src/App/Platforms/Android/Services/DeviceActionService.cs (+122 -15)
➕ src/App/Platforms/Android/Utilities/CallingAppInfoExtensions.cs (+37 -0)
📝 src/App/Platforms/iOS/AppDelegate.cs (+14 -16)
➕ src/App/Resources/Raw/fido2_priviliged_allow_list.json (+481 -0)

...and 80 more files

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Implement passkey providers for both Android & iOS.

Code changes

This is a long-lived branch where several PRs have been merged into. Check these PRs for the corresponding code changes if necessary.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3173 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 4/19/2024 **Status:** ✅ Merged **Merged:** 4/25/2024 **Merged by:** [@vvolkgang](https://github.com/vvolkgang) **Base:** `main` ← **Head:** `feature/maui-migration-passkeys` --- ### 📝 Commits (10+) - [`27306fe`](https://github.com/bitwarden/android/commit/27306fe3533411e5c10b6633d61c56d71255ed16) PM-3349 PM-3350 Added the partial MAUI Community Toolkit implementation for TouchEffect. This is a temporary solution until they finalize this and add it to their nuget package. - [`e0a3c30`](https://github.com/bitwarden/android/commit/e0a3c301fbcb4e809a5b764e4d84c44e96d71280) PM-3349 PM-3350 Changed SendViewCell and its binding to be directly against the ViewModel - [`5712639`](https://github.com/bitwarden/android/commit/5712639492ceed0cf881ebafdcc935b9c5edfdc3) Merge branch 'feature/maui-migration' of https://github.com/bitwarden/mobile into feature/maui-migration - [`5f12bb9`](https://github.com/bitwarden/android/commit/5f12bb9747d15739eeea02ef2704da9705191ee9) PM-3350 Fixed iOS Share extension lazy views loading and an issue with the avatar loading. Also discovered issue with TapGestureRecognizer not working on MAUI Embedding - [`df4d89c`](https://github.com/bitwarden/android/commit/df4d89cd52a92b2f049f2a1b5c4ef8cbb79530ce) PM-3350 Fixed iOS Extensions navigation to several pages and improved avoiding duplicate calls to OnNavigatedTo - [`beda4e9`](https://github.com/bitwarden/android/commit/beda4e9ff8edbb28398430966d6a0efb21599b8f) PM-3350 Updated PCL Crypto to latest alpha version to fix "Dll not found NCrypt" issue - [`f02b341`](https://github.com/bitwarden/android/commit/f02b3415a3c03a5d09b3ce15b4bea21f8599f33b) PM-3350 Removed workaround for iOS issue with Avatar icon as it's now fixed in latest .Net8 release. - [`2c7870d`](https://github.com/bitwarden/android/commit/2c7870d6602af62a6464e360ac627e7b760bd002) PM-3349 PM-3350 Removed AsyncCommand "wrapper" and added AsyncRelayCommand directly in all ViewModels that were using the other one. - [`eceb506`](https://github.com/bitwarden/android/commit/eceb506c7731d3658d11689a970927cdcbc14bc0) Merge branch 'master' into feature/maui-migration - [`3795f3a`](https://github.com/bitwarden/android/commit/3795f3aa171d5522a9495e1bebbad556d315fe91) PM-3350 Added watchOS app to main project and fixed some csproj conditions for runtime identifiers on iOS. ### 📊 Changes **200 files changed** (+10643 additions, -624 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -0) ➕ `lib/android/Xamarin.AndroidX.Credentials/Xamarin.AndroidX.Credentials.1.0.0.nupkg` (+0 -0) ➕ `lib/android/Xamarin.AndroidX.Credentials/net8.0-android/Xamarin.AndroidX.Credentials.dll` (+0 -0) ➕ `lib/android/Xamarin.AndroidX.Credentials/net8.0-android/Xamarin.AndroidX.Credentials.xml` (+8 -0) ➕ `lib/android/Xamarin.AndroidX.Credentials/net8.0-android/credentials-1.2.0.aar` (+0 -0) 📝 `nuget.config` (+1 -0) 📝 `src/App/App.csproj` (+8 -0) ➕ `src/App/Platforms/Android/Autofill/CredentialHelpers.cs` (+303 -0) ➕ `src/App/Platforms/Android/Autofill/CredentialProviderSelectionActivity.cs` (+172 -0) ➕ `src/App/Platforms/Android/Autofill/CredentialProviderService.cs` (+168 -0) ➕ `src/App/Platforms/Android/Autofill/Fido2GetAssertionUserInterface.cs` (+77 -0) ➕ `src/App/Platforms/Android/Autofill/Fido2MakeCredentialUserInterface.cs` (+202 -0) 📝 `src/App/Platforms/Android/MainActivity.cs` (+11 -0) 📝 `src/App/Platforms/Android/MainApplication.cs` (+54 -2) ➕ `src/App/Platforms/Android/Resources/xml/provider.xml` (+6 -0) 📝 `src/App/Platforms/Android/Services/AutofillHandler.cs` (+50 -4) 📝 `src/App/Platforms/Android/Services/DeviceActionService.cs` (+122 -15) ➕ `src/App/Platforms/Android/Utilities/CallingAppInfoExtensions.cs` (+37 -0) 📝 `src/App/Platforms/iOS/AppDelegate.cs` (+14 -16) ➕ `src/App/Resources/Raw/fido2_priviliged_allow_list.json` (+481 -0) _...and 80 more files_ </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Implement passkey providers for both Android & iOS. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> This is a long-lived branch where several PRs have been merged into. Check these PRs for the corresponding code changes if necessary. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 12:57:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#45673
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?