github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-23 17:47:57 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3164] [MERGED] [PM-7385] Fix IFido2MakeCredentialConfirmationUserInterface usages #45665

New Issue
Closed
opened 2026-04-26 12:57:10 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 12:57:10 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3164
Author: @fedemkr
Created: 4/16/2024
Status: ✅ Merged
Merged: 4/17/2024
Merged by: @fedemkr

Base: feature/maui-migration-passkeys ← Head: mobiletf/pm-7385/fix-interface-resolve-ios-issues

📝 Commits (1)

  • 5f2c04b PM-7385 Fix IFido2MakeCredentialConfirmationUserInterface resolve and usage to be constrained to Android.

📊 Changes

6 files changed (+35 additions, -12 deletions)

View changed files

📝 src/Core/App.xaml.cs (+8 -4)
📝 src/Core/Pages/Vault/CipherAddEditPage.xaml.cs (+4 -0)
📝 src/Core/Pages/Vault/CipherAddEditPageViewModel.cs (+5 -2)
📝 src/Core/Pages/Vault/CiphersPageViewModel.cs (+4 -0)
📝 src/Core/Utilities/AccountManagement/AccountsManager.cs (+6 -2)
📝 src/Core/Utilities/AppHelpers.cs (+8 -4)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix Android only interfaces to be constrained to Android on Fido2 flows.

Code changes

  • Everything: Constrained to Android the resolve and usage of IFido2MakeCredentialConfirmationUserInterface

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3164 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 4/16/2024 **Status:** ✅ Merged **Merged:** 4/17/2024 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `feature/maui-migration-passkeys` ← **Head:** `mobiletf/pm-7385/fix-interface-resolve-ios-issues` --- ### 📝 Commits (1) - [`5f2c04b`](https://github.com/bitwarden/android/commit/5f2c04b811f27fb3416b4e9e4100fae1084d86b3) PM-7385 Fix IFido2MakeCredentialConfirmationUserInterface resolve and usage to be constrained to Android. ### 📊 Changes **6 files changed** (+35 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/App.xaml.cs` (+8 -4) 📝 `src/Core/Pages/Vault/CipherAddEditPage.xaml.cs` (+4 -0) 📝 `src/Core/Pages/Vault/CipherAddEditPageViewModel.cs` (+5 -2) 📝 `src/Core/Pages/Vault/CiphersPageViewModel.cs` (+4 -0) 📝 `src/Core/Utilities/AccountManagement/AccountsManager.cs` (+6 -2) 📝 `src/Core/Utilities/AppHelpers.cs` (+8 -4) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix Android only interfaces to be constrained to Android on Fido2 flows. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **Everything:** Constrained to Android the resolve and usage of `IFido2MakeCredentialConfirmationUserInterface` ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 12:57:10 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#45665