github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-23 17:47:57 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3160] [MERGED] [PM-7367] Fix empty items state placeholder on Android cipher selection #45661

New Issue
Closed
opened 2026-04-26 12:57:00 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 12:57:00 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3160
Author: @fedemkr
Created: 4/15/2024
Status: ✅ Merged
Merged: 4/15/2024
Merged by: @fedemkr

Base: feature/maui-migration-passkeys ← Head: mobiletf/pm-7367/fix-empty-items-placeholder-android

📝 Commits (1)

  • 7d61830 PM-7367 Fix empty items state placeholder on Android cipher selection page

📊 Changes

7 files changed (+72 additions, -98 deletions)

View changed files

📝 src/App/App.csproj (+2 -0)
📝 src/Core/Core.csproj (+8 -3)
📝 src/Core/Pages/Vault/CipherSelectionPage.xaml (+1 -0)
📝 src/Core/Pages/Vault/CipherSelectionPage.xaml.cs (+17 -0)
➖ src/Core/Resources/Images/dotnet_bot.svg (+0 -95)
➕ src/Core/Resources/Images/empty_items_state.svg (+22 -0)
➕ src/Core/Resources/Images/empty_items_state_dark.svg (+22 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix empty items state placeholder on Android cipher selection

Code changes

  • Core.csproj: Added images for the empty items state as MauiImage SVGs only for Android so not to cause issues with the image on iOS Assets.
  • CipherSelectionPage: Set the new placeholder and added code for update on theme change.

Screenshots

Empty items state on Cipher Selection

Empty items state on Cipher Selection

Empty items state on Cipher Selection Dark

Empty items state on Cipher Selection Dark

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3160 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 4/15/2024 **Status:** ✅ Merged **Merged:** 4/15/2024 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `feature/maui-migration-passkeys` ← **Head:** `mobiletf/pm-7367/fix-empty-items-placeholder-android` --- ### 📝 Commits (1) - [`7d61830`](https://github.com/bitwarden/android/commit/7d6183025e5951916aa1cc650d5b275b374b052a) PM-7367 Fix empty items state placeholder on Android cipher selection page ### 📊 Changes **7 files changed** (+72 additions, -98 deletions) <details> <summary>View changed files</summary> 📝 `src/App/App.csproj` (+2 -0) 📝 `src/Core/Core.csproj` (+8 -3) 📝 `src/Core/Pages/Vault/CipherSelectionPage.xaml` (+1 -0) 📝 `src/Core/Pages/Vault/CipherSelectionPage.xaml.cs` (+17 -0) ➖ `src/Core/Resources/Images/dotnet_bot.svg` (+0 -95) ➕ `src/Core/Resources/Images/empty_items_state.svg` (+22 -0) ➕ `src/Core/Resources/Images/empty_items_state_dark.svg` (+22 -0) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix empty items state placeholder on Android cipher selection ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **Core.csproj:** Added images for the empty items state as `MauiImage` SVGs only for Android so not to cause issues with the image on iOS Assets. * **CipherSelectionPage:** Set the new placeholder and added code for update on theme change. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ### Empty items state on Cipher Selection <img width="314" alt="Empty items state on Cipher Selection" src="https://github.com/bitwarden/mobile/assets/15682323/77cbf1b6-1015-4b10-93c9-d4aa0defe913"> ### Empty items state on Cipher Selection Dark <img width="314" alt="Empty items state on Cipher Selection Dark" src="https://github.com/bitwarden/mobile/assets/15682323/df321c83-fc0b-466a-a53a-6d8c8112ce95"> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 12:57:00 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#45661