github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-07-13 05:33:07 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3125] [CLOSED] [PM-7191] Add fallback to showing passwords when trying to request passkey for websites that only support password #45641

New Issue
Closed
opened 2026-04-26 12:56:03 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 12:56:03 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3125
Author: @dinisvieira
Created: 3/31/2024
Status: ❌ Closed

Base: feature/maui-migration-passkeys ← Head: bug/PM-7191-fallback-password-ios-passkey-website

📝 Commits (1)

  • 562ea1d PM-7191 fallback to password when having RPId on iOS but no passkey for it

📊 Changes

1 file changed (+11 additions, -0 deletions)

View changed files

📝 src/iOS.Autofill/LoginListViewController.cs (+11 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

When the user tries to autofill a webpage and there’s a passkey related error, they’ll see our iOS extension open with an error message. After pressing ok, the activity indicator / loading spinner isn’t removed and search won’t work, preventing users from autofilling other credentials.
We should fallback to passwords in this scenario. This fallback is based on calling SilentCredentialDiscoveryAsync()

Code changes

During initialization we could call SilentCredentialDiscoveryAsync() to check if any passkey exists for the given RPId, if not we configure the UI to show Passwords.

  • LoginListViewController.cs:

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3125 **Author:** [@dinisvieira](https://github.com/dinisvieira) **Created:** 3/31/2024 **Status:** ❌ Closed **Base:** `feature/maui-migration-passkeys` ← **Head:** `bug/PM-7191-fallback-password-ios-passkey-website` --- ### 📝 Commits (1) - [`562ea1d`](https://github.com/bitwarden/android/commit/562ea1ded8af95a35fb2a9049935a70996eb8feb) PM-7191 fallback to password when having RPId on iOS but no passkey for it ### 📊 Changes **1 file changed** (+11 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/iOS.Autofill/LoginListViewController.cs` (+11 -0) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective When the user tries to autofill a webpage and there’s a passkey related error, they’ll see our iOS extension open with an error message. After pressing ok, the activity indicator / loading spinner isn’t removed and search won’t work, preventing users from autofilling other credentials. We should fallback to passwords in this scenario. This fallback is based on calling **SilentCredentialDiscoveryAsync()** ## Code changes During initialization we could call SilentCredentialDiscoveryAsync() to check if any passkey exists for the given RPId, if not we configure the UI to show Passwords. * **LoginListViewController.cs:** ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 12:56:03 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#45641
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?