github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-19 13:36:39 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3963] [MERGED] [PM-9755] Change error message from a toast to a dialog #4564

New Issue
Closed
opened 2025-11-26 23:46:36 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:46:36 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3963
Author: @andrebispo5
Created: 9/25/2024
Status: ✅ Merged
Merged: 9/30/2024
Merged by: @andrebispo5

Base: main ← Head: pm-9755/toast-to-dialog

📝 Commits (5)

📊 Changes

2 files changed (+28 additions, -11 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginViewModel.kt (+12 -5)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginViewModelTest.kt (+16 -6)

📄 Description

🎟️ Tracking

PM-9755

📔 Objective

On some devices, the error message for the null Duo AuthUrl did not display correctly in the toast, so it was converted to an error dialog.

📸 Screenshots

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3963 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 9/25/2024 **Status:** ✅ Merged **Merged:** 9/30/2024 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `main` ← **Head:** `pm-9755/toast-to-dialog` --- ### 📝 Commits (5) - [`02bab17`](https://github.com/bitwarden/android/commit/02bab17b312f8f3cb4e7de7985f2bfdbf4a743bf) [PM-9755] Change toast to dialog due to message size - [`2ddfd8b`](https://github.com/bitwarden/android/commit/2ddfd8b284b29d0e17dbe2aca1640eb7e3c83891) [PM-9755] Update tests - [`b58cf05`](https://github.com/bitwarden/android/commit/b58cf05160639afc3c4e5694f20aa86efbbf299f) [PM-9755] Update formatting. - [`844f6b5`](https://github.com/bitwarden/android/commit/844f6b50005b7a255c22d97f5a0756b0b45ce7f2) Merge branch 'main' into pm-9755/toast-to-dialog - [`7302089`](https://github.com/bitwarden/android/commit/7302089d161248458bb6fc67b42af217063e3ad3) [PM-9755] Update code formatting ### 📊 Changes **2 files changed** (+28 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginViewModel.kt` (+12 -5) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/twofactorlogin/TwoFactorLoginViewModelTest.kt` (+16 -6) </details> ### 📄 Description ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> [PM-9755](https://bitwarden.atlassian.net/browse/PM-9755) ## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> On some devices, the error message for the null Duo AuthUrl did not display correctly in the toast, so it was converted to an error dialog. ## 📸 Screenshots <img width="259" alt="image" src="https://github.com/user-attachments/assets/3dfd0503-31c8-4897-8ee0-bc570854f502"> <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-9755]: https://bitwarden.atlassian.net/browse/PM-9755?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:46:36 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4564
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?