github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-23 17:47:57 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #3039] [MERGED] [PM-6506] Fix double execution of command on returnType Go #45583

New Issue
Closed
opened 2026-04-26 12:53:39 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 12:53:39 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3039
Author: @andrebispo5
Created: 2/28/2024
Status: ✅ Merged
Merged: 2/28/2024
Merged by: @andrebispo5

Base: main ← Head: auth/pm-6506/environment-crash

📝 Commits (3)

  • fc9eec0 [PM-6506] Fix double execution of command on returnType Go
  • f69f7e0 [PM-6506] Hide keyboard on environment page close
  • ce97284 [PM-6506] Task guard

📊 Changes

5 files changed (+30 additions, -6 deletions)

View changed files

📝 src/Core/Pages/Accounts/EnvironmentPage.xaml.cs (+8 -1)
📝 src/Core/Pages/Accounts/EnvironmentPageViewModel.cs (+5 -2)
📝 src/iOS.Autofill/CredentialProviderViewController.cs (+5 -1)
📝 src/iOS.Extension/LoadingViewController.cs (+6 -1)
📝 src/iOS.ShareExtension/LoadingViewController.cs (+6 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix regression bug on Android where the app would crash if the "Submit" button was pressed on the keyboard while the server url entry was selected.

Code changes

Needed to replace the Action with a Func because the keyboard returnType="Go" has a bug where it can execute the associated command twice.

Screenshots

https://github.com/bitwarden/mobile/assets/4648522/2bbd9f67-f47b-47fc-b5ef-94c858efac66

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3039 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 2/28/2024 **Status:** ✅ Merged **Merged:** 2/28/2024 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `main` ← **Head:** `auth/pm-6506/environment-crash` --- ### 📝 Commits (3) - [`fc9eec0`](https://github.com/bitwarden/android/commit/fc9eec016e5209089a075dd8484f05002efb20a5) [PM-6506] Fix double execution of command on returnType Go - [`f69f7e0`](https://github.com/bitwarden/android/commit/f69f7e0d0bba0389653de2e4704e9d2b03ab9fb4) [PM-6506] Hide keyboard on environment page close - [`ce97284`](https://github.com/bitwarden/android/commit/ce97284acb7f9d7f833794a652f92b1712d7d795) [PM-6506] Task guard ### 📊 Changes **5 files changed** (+30 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Pages/Accounts/EnvironmentPage.xaml.cs` (+8 -1) 📝 `src/Core/Pages/Accounts/EnvironmentPageViewModel.cs` (+5 -2) 📝 `src/iOS.Autofill/CredentialProviderViewController.cs` (+5 -1) 📝 `src/iOS.Extension/LoadingViewController.cs` (+6 -1) 📝 `src/iOS.ShareExtension/LoadingViewController.cs` (+6 -1) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix regression bug on Android where the app would crash if the "Submit" button was pressed on the keyboard while the server url entry was selected. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> Needed to replace the Action with a Func<Task> because the keyboard returnType="Go" has a bug where it can execute the associated command twice. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> https://github.com/bitwarden/mobile/assets/4648522/2bbd9f67-f47b-47fc-b5ef-94c858efac66 ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 12:53:39 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#45583