github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 11:44:41 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3942] [MERGED] [PM-10118] update selected generator type when returning to main tab. #4545

New Issue
Closed
opened 2025-11-26 23:46:16 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:46:16 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3942
Author: @dseverns-livefront
Created: 9/19/2024
Status: ✅ Merged
Merged: 9/20/2024
Merged by: @dseverns-livefront

Base: main ← Head: PM-10118-username-type

📝 Commits (7)

📊 Changes

4 files changed (+177 additions, -16 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt (+12 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModel.kt (+40 -8)
📝 app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreenTest.kt (+17 -8)
📝 app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModelTest.kt (+108 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-10118

📔 Objective

  • User selected generation type should be sync'd across all versions of generator screen.

📸 Screenshots

https://github.com/user-attachments/assets/709a5d17-81ca-4057-ab41-2cad34337fa9

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3942 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 9/19/2024 **Status:** ✅ Merged **Merged:** 9/20/2024 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `PM-10118-username-type` --- ### 📝 Commits (7) - [`470dadf`](https://github.com/bitwarden/android/commit/470dadf243b60e32d4922551da7dd2483844c06c) PM-10118 reflect changes on the selected type on a modal to the main generator tab - [`4714654`](https://github.com/bitwarden/android/commit/471465450d6ed1395bfb369b6536bfdb09ed3a16) Pr fb - [`9f50e35`](https://github.com/bitwarden/android/commit/9f50e35dca6bd017dad8cd37ada15a4c7bdea4db) add test - [`af91626`](https://github.com/bitwarden/android/commit/af916265aeada63a3e058c365b61a872320d3616) update test - [`4fa2675`](https://github.com/bitwarden/android/commit/4fa267565dac70925708cc3d88d5cdf98ed9dad3) fix test - [`609b83b`](https://github.com/bitwarden/android/commit/609b83bfb005bb782c46a620698f665a57077a9a) add comments and update test - [`a124982`](https://github.com/bitwarden/android/commit/a1249828d3a3b73f7c98d4044c82ad7675948fc5) comma ### 📊 Changes **4 files changed** (+177 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreen.kt` (+12 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModel.kt` (+40 -8) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorScreenTest.kt` (+17 -8) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/tools/feature/generator/GeneratorViewModelTest.kt` (+108 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-10118 <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective - User selected generation type should be sync'd across all versions of generator screen. <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots https://github.com/user-attachments/assets/709a5d17-81ca-4057-ab41-2cad34337fa9 <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:46:16 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4545
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?