github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-30 17:33:42 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #2821] [MERGED] [PM-4054] Rename Fido2Key to Fido2Credential #45430

New Issue
Closed
opened 2026-04-26 12:44:03 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 12:44:03 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2821
Author: @fedemkr
Created: 10/12/2023
Status: ✅ Merged
Merged: 10/12/2023
Merged by: @fedemkr

Base: master ← Head: vault/pm-4054/rename-fido2credential

📝 Commits (2)

  • 8c7b81e PM-4054 Renamed Fido2Key to Fido2Credential on the entire codebase
  • d7227e3 PM-4054 Renamed file Fido2KeyApi to Fido2CredentialApi

📊 Changes

15 files changed (+56 additions, -56 deletions)

View changed files

📝 src/App/Pages/Vault/CipherAddEditPageViewModel.cs (+2 -2)
📝 src/App/Pages/Vault/CipherDetailsPage.xaml (+2 -2)
📝 src/App/Pages/Vault/CipherDetailsPageViewModel.cs (+1 -1)
📝 src/Core/Constants.cs (+3 -3)
📝 src/Core/Models/Api/Fido2CredentialApi.cs (+6 -6)
📝 src/Core/Models/Api/LoginApi.cs (+1 -1)
📝 src/Core/Models/Data/Fido2CredentialData.cs (+6 -6)
📝 src/Core/Models/Data/LoginData.cs (+2 -2)
📝 src/Core/Models/Domain/Fido2Credential.cs (+7 -7)
📝 src/Core/Models/Domain/Login.cs (+8 -8)
📝 src/Core/Models/Request/CipherRequest.cs (+1 -1)
📝 src/Core/Models/View/CipherView.cs (+1 -1)
📝 src/Core/Models/View/Fido2CredentialView.cs (+5 -5)
📝 src/Core/Models/View/LoginView.cs (+3 -3)
📝 src/Core/Services/CipherService.cs (+8 -8)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Rename Fido2Key to Fido2Credential on the entire codebase to comply with the WebAuthn spec.

Code changes

  • Renaming

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2821 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 10/12/2023 **Status:** ✅ Merged **Merged:** 10/12/2023 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `vault/pm-4054/rename-fido2credential` --- ### 📝 Commits (2) - [`8c7b81e`](https://github.com/bitwarden/android/commit/8c7b81ee0a1df14c3a6dd4f2c47c3803e97498c4) PM-4054 Renamed Fido2Key to Fido2Credential on the entire codebase - [`d7227e3`](https://github.com/bitwarden/android/commit/d7227e3be662ef2280f77ee448100cf1fcec8876) PM-4054 Renamed file Fido2KeyApi to Fido2CredentialApi ### 📊 Changes **15 files changed** (+56 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Vault/CipherAddEditPageViewModel.cs` (+2 -2) 📝 `src/App/Pages/Vault/CipherDetailsPage.xaml` (+2 -2) 📝 `src/App/Pages/Vault/CipherDetailsPageViewModel.cs` (+1 -1) 📝 `src/Core/Constants.cs` (+3 -3) 📝 `src/Core/Models/Api/Fido2CredentialApi.cs` (+6 -6) 📝 `src/Core/Models/Api/LoginApi.cs` (+1 -1) 📝 `src/Core/Models/Data/Fido2CredentialData.cs` (+6 -6) 📝 `src/Core/Models/Data/LoginData.cs` (+2 -2) 📝 `src/Core/Models/Domain/Fido2Credential.cs` (+7 -7) 📝 `src/Core/Models/Domain/Login.cs` (+8 -8) 📝 `src/Core/Models/Request/CipherRequest.cs` (+1 -1) 📝 `src/Core/Models/View/CipherView.cs` (+1 -1) 📝 `src/Core/Models/View/Fido2CredentialView.cs` (+5 -5) 📝 `src/Core/Models/View/LoginView.cs` (+3 -3) 📝 `src/Core/Services/CipherService.cs` (+8 -8) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Rename `Fido2Key` to `Fido2Credential` on the entire codebase to comply with the WebAuthn spec. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * Renaming ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 12:44:03 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#45430