github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 04:16:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2810] [MERGED] [PM-2364] Fix settings inaccessible when language is set to Turkish #45422

New Issue
Closed
opened 2026-04-26 12:43:25 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 12:43:25 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2810
Author: @aj-rosado
Created: 10/3/2023
Status: ✅ Merged
Merged: 10/10/2023
Merged by: @aj-rosado

Base: master ← Head: bugfix/PM-2364-options-menu-inaccessible-turkish-lang

📝 Commits (1)

  • b63c76d Added CultureInfo in char.ToLower at GetServiceRegistrationName method

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 src/Core/Utilities/ServiceContainer.cs (+2 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fixes #2534

Users using Turkish language were unable to access the settings page.

This was caused by an exception when trying to resolve the II18nService. That is caused by the lower case of "I" being "ı" in Turkish language so the GetServiceRegistrationName is returning ı18nService instead of i18nService.

Code changes

  • ServiceContainer.cs: Set the CultureInfo to en-US on the char.ToLower to use the expected alphabet

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2810 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 10/3/2023 **Status:** ✅ Merged **Merged:** 10/10/2023 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `master` ← **Head:** `bugfix/PM-2364-options-menu-inaccessible-turkish-lang` --- ### 📝 Commits (1) - [`b63c76d`](https://github.com/bitwarden/android/commit/b63c76dbdd36e58432047a15bbe1fbabc2ea60c2) Added CultureInfo in char.ToLower at GetServiceRegistrationName method ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Utilities/ServiceContainer.cs` (+2 -1) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Fixes #2534 Users using Turkish language were unable to access the settings page. This was caused by an exception when trying to resolve the `II18nService`. That is caused by the lower case of "I" being "ı" in Turkish language so the `GetServiceRegistrationName` is returning ı18nService instead of i18nService. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **ServiceContainer.cs:** Set the `CultureInfo` to `en-US` on the `char.ToLower` to use the expected alphabet ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 12:43:25 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#45422
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?