github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 04:16:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2735] [MERGED] [PM-3511] Implemented new Auto-fill Settings View #45379

New Issue
Closed
opened 2026-04-26 12:40:12 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 12:40:12 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2735
Author: @fedemkr
Created: 8/29/2023
Status: ✅ Merged
Merged: 8/30/2023
Merged by: @fedemkr

Base: vault/pm-2658/feature-settings-reorganization ← Head: vault/pm-3511/settings-autofill

📝 Commits (2)

  • 9b6bf10 PM-3511 Implemented autofill settings view
  • 3a942d7 Merge branch 'vault/pm-2658/feature-settings-reorganization' into vault/pm-3511/settings-autofill

📊 Changes

20 files changed (+587 additions, -31 deletions)

View changed files

📝 src/Android/Services/DeviceActionService.cs (+38 -0)
📝 src/App/Abstractions/IDeviceActionService.cs (+5 -0)
📝 src/App/App.xaml.cs (+1 -1)
📝 src/App/Pages/Settings/AutofillSettingsPage.xaml (+118 -1)
📝 src/App/Pages/Settings/AutofillSettingsPage.xaml.cs (+28 -3)
➕ src/App/Pages/Settings/AutofillSettingsPageViewModel.android.cs (+181 -0)
📝 src/App/Pages/Settings/AutofillSettingsPageViewModel.cs (+103 -3)
➕ src/App/Pages/Settings/AutofillSettingsPageViewModel.ios.cs (+19 -0)
📝 src/App/Pages/Settings/SecuritySettingsPage.xaml (+3 -18)
📝 src/App/Pages/Settings/SecuritySettingsPageViewModel.cs (+1 -1)
📝 src/App/Resources/AppResources.Designer.cs (+27 -0)
📝 src/App/Resources/AppResources.resx (+9 -0)
📝 src/App/Styles/Android.xaml (+14 -0)
📝 src/App/Styles/Base.xaml (+10 -0)
📝 src/App/Styles/iOS.xaml (+14 -0)
📝 src/App/Utilities/AppHelpers.cs (+1 -0)
📝 src/Core/Services/StateService.cs (+4 -0)
📝 src/iOS.Core/Services/AutofillHandler.cs (+3 -3)
📝 src/iOS.Core/Services/DeviceActionService.cs (+7 -0)
📝 src/iOS/AppDelegate.cs (+1 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Implement new Settings view for Auto-fill.

Code changes

  • DeviceActionService.cs: Moved platform specific checks to be done here.
  • AutofillSettingsPage: Implemented new autofill settings view.
  • AutofillSettingsPageViewModel.cs/.android.cs/.ios.cs: New ViewModel for autofill settings view. This is in three different files as partial classes to divide specific logic for Common/Android/iOS.
  • SecuritySettingsPage.xaml: Updated Styles
  • Base/Android/iOS.xaml: Added new styles for settings
  • AutofillHandler.cs: Updated behavior here to not break new approach of autofill settings.

Screenshots

Autofill settings Android Light 1

Autofill settings Android Light 1

Autofill settings Android Light 2

Autofill settings Android Light 2

Autofill settings Android Dark 1

Autofill settings Android Dark 1

Autofill settings Android Dark 2

Autofill settings Android Dark 2

Autofill settings iOS Light

Autofill settings iOS Light

Autofill settings iOS Dark

Autofill settings iOS Dark

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2735 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 8/29/2023 **Status:** ✅ Merged **Merged:** 8/30/2023 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `vault/pm-2658/feature-settings-reorganization` ← **Head:** `vault/pm-3511/settings-autofill` --- ### 📝 Commits (2) - [`9b6bf10`](https://github.com/bitwarden/android/commit/9b6bf1009b550459d413f2f2fa4a99c28a9c71c3) PM-3511 Implemented autofill settings view - [`3a942d7`](https://github.com/bitwarden/android/commit/3a942d75156a8c6bfb67861ec2e8fbb8c7c058a8) Merge branch 'vault/pm-2658/feature-settings-reorganization' into vault/pm-3511/settings-autofill ### 📊 Changes **20 files changed** (+587 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Services/DeviceActionService.cs` (+38 -0) 📝 `src/App/Abstractions/IDeviceActionService.cs` (+5 -0) 📝 `src/App/App.xaml.cs` (+1 -1) 📝 `src/App/Pages/Settings/AutofillSettingsPage.xaml` (+118 -1) 📝 `src/App/Pages/Settings/AutofillSettingsPage.xaml.cs` (+28 -3) ➕ `src/App/Pages/Settings/AutofillSettingsPageViewModel.android.cs` (+181 -0) 📝 `src/App/Pages/Settings/AutofillSettingsPageViewModel.cs` (+103 -3) ➕ `src/App/Pages/Settings/AutofillSettingsPageViewModel.ios.cs` (+19 -0) 📝 `src/App/Pages/Settings/SecuritySettingsPage.xaml` (+3 -18) 📝 `src/App/Pages/Settings/SecuritySettingsPageViewModel.cs` (+1 -1) 📝 `src/App/Resources/AppResources.Designer.cs` (+27 -0) 📝 `src/App/Resources/AppResources.resx` (+9 -0) 📝 `src/App/Styles/Android.xaml` (+14 -0) 📝 `src/App/Styles/Base.xaml` (+10 -0) 📝 `src/App/Styles/iOS.xaml` (+14 -0) 📝 `src/App/Utilities/AppHelpers.cs` (+1 -0) 📝 `src/Core/Services/StateService.cs` (+4 -0) 📝 `src/iOS.Core/Services/AutofillHandler.cs` (+3 -3) 📝 `src/iOS.Core/Services/DeviceActionService.cs` (+7 -0) 📝 `src/iOS/AppDelegate.cs` (+1 -1) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Implement new Settings view for Auto-fill. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **DeviceActionService.cs:** Moved platform specific checks to be done here. * **AutofillSettingsPage:** Implemented new autofill settings view. * **AutofillSettingsPageViewModel.cs/.android.cs/.ios.cs:** New ViewModel for autofill settings view. This is in three different files as partial classes to divide specific logic for Common/Android/iOS. * **SecuritySettingsPage.xaml:** Updated Styles * **Base/Android/iOS.xaml:** Added new styles for settings * **AutofillHandler.cs:** Updated behavior here to not break new approach of autofill settings. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ### Autofill settings Android Light 1 <img width="314" alt="Autofill settings Android Light 1" src="https://github.com/bitwarden/mobile/assets/15682323/db487e6f-bc7f-4648-b544-5d07ff823d7f"> ### Autofill settings Android Light 2 <img width="314" alt="Autofill settings Android Light 2" src="https://github.com/bitwarden/mobile/assets/15682323/4f9b834e-d3c7-4e91-996e-b5b08c813505"> ### Autofill settings Android Dark 1 <img width="314" alt="Autofill settings Android Dark 1" src="https://github.com/bitwarden/mobile/assets/15682323/c30a5948-bc3b-4e1b-bc62-c4a1200611c8"> ### Autofill settings Android Dark 2 <img width="314" alt="Autofill settings Android Dark 2" src="https://github.com/bitwarden/mobile/assets/15682323/43882571-f3b2-4e69-b62a-a60b9674a9ba"> ### Autofill settings iOS Light <img width="314" alt="Autofill settings iOS Light" src="https://github.com/bitwarden/mobile/assets/15682323/e63b4482-fc8b-456c-9352-a4df12638fea"> ### Autofill settings iOS Dark <img width="314" alt="Autofill settings iOS Dark" src="https://github.com/bitwarden/mobile/assets/15682323/badb4399-e29e-4961-868c-1acf0a53f345"> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 12:40:12 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#45379
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?