github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 04:16:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2679] [MERGED] [PM-3303] Fix biometric login after key migration #45332

New Issue
Closed
opened 2026-04-26 12:36:00 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 12:36:00 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2679
Author: @andrebispo5
Created: 8/11/2023
Status: ✅ Merged
Merged: 8/11/2023
Merged by: @andrebispo5

Base: feature/pm-1029-tde-login ← Head: auth/pm-3303-biometric-login

📝 Commits (2)

  • 4109436 [PM-3381] Fix login with biometrics.
  • 405a9ad [PM-3303] Add condition to biometric unlock

📊 Changes

2 files changed (+1 additions, -2 deletions)

View changed files

📝 src/App/Pages/Accounts/LockPageViewModel.cs (+0 -1)
📝 src/App/Services/BaseBiometricService.cs (+1 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix login with biometric after key migration.

Code changes

Wrong validation was causing BiometricEnabled property never setting as true.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2679 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 8/11/2023 **Status:** ✅ Merged **Merged:** 8/11/2023 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `feature/pm-1029-tde-login` ← **Head:** `auth/pm-3303-biometric-login` --- ### 📝 Commits (2) - [`4109436`](https://github.com/bitwarden/android/commit/410943601b8bf3afe395c54fb457a751a784fb65) [PM-3381] Fix login with biometrics. - [`405a9ad`](https://github.com/bitwarden/android/commit/405a9ad327e96a7abf0c16d7c89c8ea073110a03) [PM-3303] Add condition to biometric unlock ### 📊 Changes **2 files changed** (+1 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/LockPageViewModel.cs` (+0 -1) 📝 `src/App/Services/BaseBiometricService.cs` (+1 -1) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix login with biometric after key migration. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> Wrong validation was causing `BiometricEnabled` property never setting as true. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 12:36:00 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#45332
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?