github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-15 06:59:05 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3919] [MERGED] PM-12014: Enable accessibility autofill outside of debug builds #4522

New Issue
Closed
opened 2025-11-26 23:45:51 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:45:51 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3919
Author: @david-livefront
Created: 9/16/2024
Status: ✅ Merged
Merged: 9/18/2024
Merged by: @david-livefront

Base: main ← Head: PM-12014-release-accessibility

📝 Commits (1)

  • 75ebc2d PM-12014: Enable accessibility autofill outside of debug builds

📊 Changes

3 files changed (+38 additions, -41 deletions)

View changed files

📝 app/src/debug/AndroidManifest.xml (+0 -38)
📝 app/src/main/AndroidManifest.xml (+38 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillScreen.kt (+0 -3)

📄 Description

🎟️ Tracking

PM-12014

📔 Objective

This PR moves the manifest items for accessibility autofill from the debug manifest to the main manifest, allowing them to be used in all build variants. The UI switch for enabling accessibility autofill has also been enabled in non-debug builds.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3919 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 9/16/2024 **Status:** ✅ Merged **Merged:** 9/18/2024 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-12014-release-accessibility` --- ### 📝 Commits (1) - [`75ebc2d`](https://github.com/bitwarden/android/commit/75ebc2d6b3b76b55320b44e5ec53d22cd5791ab6) PM-12014: Enable accessibility autofill outside of debug builds ### 📊 Changes **3 files changed** (+38 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `app/src/debug/AndroidManifest.xml` (+0 -38) 📝 `app/src/main/AndroidManifest.xml` (+38 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillScreen.kt` (+0 -3) </details> ### 📄 Description ## 🎟️ Tracking [PM-12014](https://bitwarden.atlassian.net/browse/PM-12014) ## 📔 Objective This PR moves the manifest items for accessibility autofill from the debug manifest to the main manifest, allowing them to be used in all build variants. The UI switch for enabling accessibility autofill has also been enabled in non-debug builds. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-12014]: https://bitwarden.atlassian.net/browse/PM-12014?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:45:51 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4522
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?