github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 11:29:37 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2388] [MERGED] [PS-2520] Restore copy confirmation toast on Android 13+ #45137

New Issue
Closed
opened 2026-04-26 12:22:11 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 12:22:11 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2388
Author: @mpbw2
Created: 2/21/2023
Status: ✅ Merged
Merged: 2/21/2023
Merged by: @mpbw2

Base: master ← Head: bugfix/restore-copy-toast

📝 Commits (2)

  • 953d8cc Restore copy notification toast on Android 13+
  • 5f92316 fixed space

📊 Changes

4 files changed (+1 additions, -22 deletions)

View changed files

📝 src/Android/Services/ClipboardService.cs (+0 -6)
📝 src/App/Services/MobilePlatformUtilsService.cs (+1 -5)
📝 src/Core/Abstractions/IClipboardService.cs (+0 -5)
📝 src/iOS.Core/Services/ClipboardService.cs (+0 -6)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Copy confirmation toasts were originally removed on Android 13+ devices since the system provides its own notification now. However we’re seeing that functionality removed by some device makers, giving users the impression that copy isn’t working at all. As there’s no official way to know if this is happening, we're restoring the toast across the board. Better to have some overlap than no notification at all.

Code changes

  • ClipboardService.cs: Removed IsCopyNotificationHandledByPlatform method
  • MobilePlatformUtilsService.cs: Removed _clipboardService.IsCopyNotificationHandledByPlatform check before showing toast

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2388 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 2/21/2023 **Status:** ✅ Merged **Merged:** 2/21/2023 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `bugfix/restore-copy-toast` --- ### 📝 Commits (2) - [`953d8cc`](https://github.com/bitwarden/android/commit/953d8ccb12862397f44c3d9bd00d1d2f7f910b38) Restore copy notification toast on Android 13+ - [`5f92316`](https://github.com/bitwarden/android/commit/5f923161310385ff67a814547a6ca6dccb039f49) fixed space ### 📊 Changes **4 files changed** (+1 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Services/ClipboardService.cs` (+0 -6) 📝 `src/App/Services/MobilePlatformUtilsService.cs` (+1 -5) 📝 `src/Core/Abstractions/IClipboardService.cs` (+0 -5) 📝 `src/iOS.Core/Services/ClipboardService.cs` (+0 -6) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Copy confirmation toasts were originally removed on Android 13+ devices since the system provides its own notification now. However we’re seeing that functionality removed by some device makers, giving users the impression that copy isn’t working at all. As there’s no official way to know if this is happening, we're restoring the toast across the board. Better to have some overlap than no notification at all. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **ClipboardService.cs:** Removed `IsCopyNotificationHandledByPlatform` method * **MobilePlatformUtilsService.cs:** Removed `_clipboardService.IsCopyNotificationHandledByPlatform` check before showing toast ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 12:22:11 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#45137
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?