github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 15:58:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2354] [MERGED] Use encoded query parameters over path #45121

New Issue
Closed
opened 2026-04-26 12:20:53 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 12:20:53 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2354
Author: @MGibson1
Created: 2/9/2023
Status: ✅ Merged
Merged: 3/7/2023
Merged by: @MGibson1

Base: master ← Head: auth/ps-2465-fix-knowndevices-path

📝 Commits (6)

  • 6344133 Use encoded query parameters over path
  • a79edb5 Prefer POST for requests with sensitive information
  • 4e7b987 Send private information in headers over query
  • f12b8de B64 encode email
  • 732ccda Merge remote-tracking branch 'origin/master' into auth/ps-2465-fix-knowndevices-path
  • 7e8f764 Merge branch 'master' into auth/ps-2465-fix-knowndevices-path

📊 Changes

2 files changed (+11 additions, -5 deletions)

View changed files

📝 src/Core/Abstractions/IApiService.cs (+1 -1)
📝 src/Core/Services/ApiService.cs (+10 -4)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Prefer query parameters for things like email

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2354 **Author:** [@MGibson1](https://github.com/MGibson1) **Created:** 2/9/2023 **Status:** ✅ Merged **Merged:** 3/7/2023 **Merged by:** [@MGibson1](https://github.com/MGibson1) **Base:** `master` ← **Head:** `auth/ps-2465-fix-knowndevices-path` --- ### 📝 Commits (6) - [`6344133`](https://github.com/bitwarden/android/commit/6344133a0aa414911803d0096d2676937a9924b2) Use encoded query parameters over path - [`a79edb5`](https://github.com/bitwarden/android/commit/a79edb5e4c5b451a21686c20ce62e48df18bd222) Prefer POST for requests with sensitive information - [`4e7b987`](https://github.com/bitwarden/android/commit/4e7b987d1cfff5d4ee5af7bccf3d6201da149cbd) Send private information in headers over query - [`f12b8de`](https://github.com/bitwarden/android/commit/f12b8de45dc68f569915c554d64ae26f7bb30007) B64 encode email - [`732ccda`](https://github.com/bitwarden/android/commit/732ccda3ddacb4a81e0321f9d53685bc878a4fdf) Merge remote-tracking branch 'origin/master' into auth/ps-2465-fix-knowndevices-path - [`7e8f764`](https://github.com/bitwarden/android/commit/7e8f7642851ea8ed6e0c700cdb17f2d165415ca8) Merge branch 'master' into auth/ps-2465-fix-knowndevices-path ### 📊 Changes **2 files changed** (+11 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Abstractions/IApiService.cs` (+1 -1) 📝 `src/Core/Services/ApiService.cs` (+10 -4) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Prefer query parameters for things like email ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 12:20:53 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#45121
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?