github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-24 14:28:58 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #2278] [MERGED] [EC-763] Cake build watchOS #45080

New Issue
Closed
opened 2026-04-26 12:18:04 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 12:18:04 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2278
Author: @fedemkr
Created: 1/5/2023
Status: ✅ Merged
Merged: 2/20/2023
Merged by: @fedemkr

Base: master ← Head: EC-763-cake-build-watchos

📝 Commits (7)

  • ad03020 EC-763 Implemented watchOS parts on cake build
  • e37848b Merge branch 'master' into EC-763-cake-build-watchos
  • ee6ee05 Merge branch 'master' into EC-763-cake-build-watchos
  • ba63598 EC-763 Improved setting the version name of the watch by caching the version on when updating the ios info plist file
  • 92ba7a6 EC-763 Fix cake build criteria to use lambda version so that it takes into consideration that the field might change on executing the script
  • a963810 EC-763 Added iOS and watchOS icons update to the cake build script
  • ff0c71f Merge branch 'master' into EC-763-cake-build-watchos

📊 Changes

12 files changed (+320 additions, -6 deletions)

View changed files

➕ appIcons/Android/beta-layered-excluded.svg (+11 -0)
➕ appIcons/Android/beta-layered.svg (+17 -0)
➕ appIcons/Android/dev-layered-excluded.svg (+11 -0)
➕ appIcons/Android/dev-layered.svg (+17 -0)
➕ appIcons/Android/qa-layered-excluded.svg (+11 -0)
➕ appIcons/Android/qa-layered.svg (+17 -0)
➕ appIcons/iOS/beta.png (+0 -0)
➕ appIcons/iOS/dev.png (+0 -0)
➕ appIcons/iOS/prod.png (+0 -0)
➕ appIcons/iOS/qa.png (+0 -0)
➕ appIcons/icongen.sh (+136 -0)
📝 build.cake (+100 -6)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Implemented watchOS parts on cake build and iOS / watchOS icons update

Code changes

  • build.cake: Added replacement of bundle id and version on watchOS related files. I couldn't find a Cake extension to handle pbxproj files so I just replace by using a regex. Also added icons update for iOS and watchOS

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2278 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 1/5/2023 **Status:** ✅ Merged **Merged:** 2/20/2023 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `EC-763-cake-build-watchos` --- ### 📝 Commits (7) - [`ad03020`](https://github.com/bitwarden/android/commit/ad0302032ad39d994956f8b3eeacf4a3d3a01e8f) EC-763 Implemented watchOS parts on cake build - [`e37848b`](https://github.com/bitwarden/android/commit/e37848b8ce132dedecfa219ab4ea7730abb9eee8) Merge branch 'master' into EC-763-cake-build-watchos - [`ee6ee05`](https://github.com/bitwarden/android/commit/ee6ee056d5226782e5b8a5a13afeef7282db12a7) Merge branch 'master' into EC-763-cake-build-watchos - [`ba63598`](https://github.com/bitwarden/android/commit/ba635980f4d688799a04fc44b5de08ae4741f0dd) EC-763 Improved setting the version name of the watch by caching the version on when updating the ios info plist file - [`92ba7a6`](https://github.com/bitwarden/android/commit/92ba7a6adf3871dff8bf65be761f8cda0d2e720f) EC-763 Fix cake build criteria to use lambda version so that it takes into consideration that the field might change on executing the script - [`a963810`](https://github.com/bitwarden/android/commit/a963810b9dd5997bedd0dba573bba26c066896e2) EC-763 Added iOS and watchOS icons update to the cake build script - [`ff0c71f`](https://github.com/bitwarden/android/commit/ff0c71f288de9374834ee652a3a0cb818db3562d) Merge branch 'master' into EC-763-cake-build-watchos ### 📊 Changes **12 files changed** (+320 additions, -6 deletions) <details> <summary>View changed files</summary> ➕ `appIcons/Android/beta-layered-excluded.svg` (+11 -0) ➕ `appIcons/Android/beta-layered.svg` (+17 -0) ➕ `appIcons/Android/dev-layered-excluded.svg` (+11 -0) ➕ `appIcons/Android/dev-layered.svg` (+17 -0) ➕ `appIcons/Android/qa-layered-excluded.svg` (+11 -0) ➕ `appIcons/Android/qa-layered.svg` (+17 -0) ➕ `appIcons/iOS/beta.png` (+0 -0) ➕ `appIcons/iOS/dev.png` (+0 -0) ➕ `appIcons/iOS/prod.png` (+0 -0) ➕ `appIcons/iOS/qa.png` (+0 -0) ➕ `appIcons/icongen.sh` (+136 -0) 📝 `build.cake` (+100 -6) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Implemented watchOS parts on cake build and iOS / watchOS icons update ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **build.cake:** Added replacement of bundle id and version on watchOS related files. I couldn't find a Cake extension to handle pbxproj files so I just replace by using a regex. Also added icons update for iOS and watchOS ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 12:18:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#45080