github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 11:29:37 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2150] [MERGED] [SG-769] Fix crash by ensuring that token for decoding is refreshed before use #44989

New Issue
Closed
opened 2026-04-26 12:13:09 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 12:13:09 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2150
Author: @LRNcardozoWDF
Created: 10/25/2022
Status: ✅ Merged
Merged: 10/31/2022
Merged by: @trmartin4

Base: master ← Head: bug/SG-769-Fix-crash-when-clicking-generate-password

📝 Commits (1)

  • b6cc447 SG-769 - Ensured token for decoding is refreshed before use

📊 Changes

3 files changed (+7 additions, -0 deletions)

View changed files

📝 src/App/Pages/Generator/GeneratorPageViewModel.cs (+1 -0)
📝 src/Core/Abstractions/ITokenService.cs (+1 -0)
📝 src/Core/Services/TokenService.cs (+5 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Added a call to refresh the token used for decoding before getting the user's email in order to fix a crash.

Code changes

  • ITokenService.cs
  • TokenService.cs : Added new method to refresh token without returning it.
  • GeneratorPageViewModel.cs : Made sure token is refreshed before using it to get user's email.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2150 **Author:** [@LRNcardozoWDF](https://github.com/LRNcardozoWDF) **Created:** 10/25/2022 **Status:** ✅ Merged **Merged:** 10/31/2022 **Merged by:** [@trmartin4](https://github.com/trmartin4) **Base:** `master` ← **Head:** `bug/SG-769-Fix-crash-when-clicking-generate-password` --- ### 📝 Commits (1) - [`b6cc447`](https://github.com/bitwarden/android/commit/b6cc447dd63a6a6c01c7d22bc0ccb8601d2e00ef) SG-769 - Ensured token for decoding is refreshed before use ### 📊 Changes **3 files changed** (+7 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Generator/GeneratorPageViewModel.cs` (+1 -0) 📝 `src/Core/Abstractions/ITokenService.cs` (+1 -0) 📝 `src/Core/Services/TokenService.cs` (+5 -0) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Added a call to refresh the token used for decoding before getting the user's email in order to fix a crash. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **ITokenService.cs** * **TokenService.cs :** Added new method to refresh token without returning it. * **GeneratorPageViewModel.cs :** Made sure token is refreshed before using it to get user's email. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 12:13:09 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#44989
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?