github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 04:16:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2141] [MERGED] [PS-1188] Add new Solarized Dark Theme #44985

New Issue
Closed
opened 2026-04-26 12:12:55 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 12:12:55 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2141
Author: @aj-rosado
Created: 10/18/2022
Status: ✅ Merged
Merged: 10/19/2022
Merged by: @aj-rosado

Base: master ← Head: feature/PS-1188-Add-Solarized-Dark-Theme

📝 Commits (4)

  • d1fabe4 PS-1188 Add new Solarized Dark Theme
  • a0f4829 PS-1188 Add new Solarized Dark Theme to the DarkDefault themes list
  • 683928e Merge branch 'master' into feature/PS-1188-Add-Solarized-Dark-Theme
  • 55845ce PS-1188 Added missing AppResources.Designer.cs file changes

📊 Changes

6 files changed (+108 additions, -0 deletions)

View changed files

📝 src/App/Pages/Settings/OptionsPageViewModel.cs (+2 -0)
📝 src/App/Resources/AppResources.Designer.cs (+9 -0)
📝 src/App/Resources/AppResources.resx (+4 -0)
➕ src/App/Styles/SolarizedDark.xaml (+76 -0)
➕ src/App/Styles/SolarizedDark.xaml.cs (+12 -0)
📝 src/App/Utilities/ThemeManager.cs (+5 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Added a new Solarized Dark theme for the mobile apps.

Code changes

  • OptionsPageViewModel.cs: Added new KeyValuePair on the theme options
  • AppResources.resx: Added string title of the new Solarized Dark theme
  • SolarizedDark.xaml: The new theme colors scheme
  • ThemeManager.cs: Added the new theme

Screenshots

iOS:
Simulator Screen Shot - iPhone SE (3rd generation) - 2022-10-14 at 17 46 14
Simulator Screen Shot - iP<br> Simulator Screen Shot - iPhone SE (3rd generation) - 2022-10-14 at 17 45 48<br> hone SE (3rd generation) - 2022-10-14 at 17 45 39
Simulator Screen Shot - iPhone SE (3rd generation) - 2022-10-14 at 17 45 45

Android:

Screenshot_1665766254
Screenshot_1665766281
Screenshot_1666110826

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2141 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 10/18/2022 **Status:** ✅ Merged **Merged:** 10/19/2022 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `master` ← **Head:** `feature/PS-1188-Add-Solarized-Dark-Theme` --- ### 📝 Commits (4) - [`d1fabe4`](https://github.com/bitwarden/android/commit/d1fabe4b7e072bc3a38317be1346a4c02653c408) PS-1188 Add new Solarized Dark Theme - [`a0f4829`](https://github.com/bitwarden/android/commit/a0f48295a1abadb352242d48b453f9c7a0bf13f3) PS-1188 Add new Solarized Dark Theme to the DarkDefault themes list - [`683928e`](https://github.com/bitwarden/android/commit/683928eae4aaf87361a28046819341e67ab2b2c5) Merge branch 'master' into feature/PS-1188-Add-Solarized-Dark-Theme - [`55845ce`](https://github.com/bitwarden/android/commit/55845ce4bec0c1d0f5a0609f39639d640899eaab) PS-1188 Added missing AppResources.Designer.cs file changes ### 📊 Changes **6 files changed** (+108 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Settings/OptionsPageViewModel.cs` (+2 -0) 📝 `src/App/Resources/AppResources.Designer.cs` (+9 -0) 📝 `src/App/Resources/AppResources.resx` (+4 -0) ➕ `src/App/Styles/SolarizedDark.xaml` (+76 -0) ➕ `src/App/Styles/SolarizedDark.xaml.cs` (+12 -0) 📝 `src/App/Utilities/ThemeManager.cs` (+5 -0) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [x] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Added a new Solarized Dark theme for the mobile apps. ## Code changes * **OptionsPageViewModel.cs:** Added new KeyValuePair on the theme options * **AppResources.resx:** Added string title of the new Solarized Dark theme * **SolarizedDark.xaml:** The new theme colors scheme * **ThemeManager.cs:** Added the new theme ## Screenshots iOS: ![Simulator Screen Shot - iPhone SE (3rd generation) - 2022-10-14 at 17 46 14](https://user-images.githubusercontent.com/109146700/196489708-81211af8-fc4c-459b-a94c-d7edbf442a0d.png) ![Simulator Screen Shot - iP ![Simulator Screen Shot - iPhone SE (3rd generation) - 2022-10-14 at 17 45 48](https://user-images.githubusercontent.com/109146700/196489705-fd041c60-d5be-4452-ba5b-2b8d82eda8fe.png) hone SE (3rd generation) - 2022-10-14 at 17 45 39](https://user-images.githubusercontent.com/109146700/196489692-3a72fd76-915e-49b0-9b69-c6759d7214cb.png) ![Simulator Screen Shot - iPhone SE (3rd generation) - 2022-10-14 at 17 45 45](https://user-images.githubusercontent.com/109146700/196489698-f2fdc120-41e2-48b5-934e-dfe52f720dd1.png) Android: ![Screenshot_1665766254](https://user-images.githubusercontent.com/109146700/196490055-abfcf557-2831-4370-94d8-ce3fdbd4b3d0.png) ![Screenshot_1665766281](https://user-images.githubusercontent.com/109146700/196490058-308a0eae-7248-48f7-889f-2a87e8c549d7.png) ![Screenshot_1666110826](https://user-images.githubusercontent.com/109146700/196490075-5b4d1989-4963-47fb-a65b-6e353360e973.png) ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 12:12:55 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#44985
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?