github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3888] [MERGED] BITAU-98 Add EncryptionUtils helper functions to the bridge SDK #4497

New Issue
Closed
opened 2025-11-26 23:45:24 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:45:24 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3888
Author: @ahaisting-livefront
Created: 9/9/2024
Status: ✅ Merged
Merged: 9/12/2024
Merged by: @ahaisting-livefront

Base: main ← Head: encryption-utils

📝 Commits (10+)

  • 5f14e2b BITAU-98 Add EncryptionUtils helper functions to the bridge SDK
  • e377d57 newline
  • 048af58 bump bridge version 0.2.0
  • 85e3e70 update bridge CHANGELOG
  • 60ad525 revert to 0.1.0 and empty CHANGELOG, holding off for 1.0.0
  • 8ca7123 newline
  • aaed2fd update comment formatting
  • d3191a8 remove return@runCatching
  • af046f9 rename and move test constants
  • d503887 update test names

📊 Changes

4 files changed (+399 additions, -2 deletions)

View changed files

📝 bridge/src/main/java/com/bitwarden/bridge/model/AddTotpLoginItemDataJson.kt (+1 -1)
📝 bridge/src/main/java/com/bitwarden/bridge/model/SharedAccountDataJson.kt (+1 -1)
➕ bridge/src/main/java/com/bitwarden/bridge/util/EncryptionUtils.kt (+204 -0)
➕ bridge/src/test/java/com/bitwarden/bridge/util/EncryptionUtilTest.kt (+193 -0)

📄 Description

🎟️ Tracking

https://livefront.atlassian.net/browse/BITAU-98

📔 Objective

The goal of this PR is to set up basic encryption/decryption logic in the Bridge SDK. This will be called by the PMA in future tickets when generating symmetric key, checking symmetric key, and ultimately implementing BridgeService.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3888 **Author:** [@ahaisting-livefront](https://github.com/ahaisting-livefront) **Created:** 9/9/2024 **Status:** ✅ Merged **Merged:** 9/12/2024 **Merged by:** [@ahaisting-livefront](https://github.com/ahaisting-livefront) **Base:** `main` ← **Head:** `encryption-utils` --- ### 📝 Commits (10+) - [`5f14e2b`](https://github.com/bitwarden/android/commit/5f14e2bbab12f7e1a2f3283ef6561d755b2ec0eb) BITAU-98 Add EncryptionUtils helper functions to the bridge SDK - [`e377d57`](https://github.com/bitwarden/android/commit/e377d5764763cd1a3b25d49cc4be9df80ce45498) newline - [`048af58`](https://github.com/bitwarden/android/commit/048af588bc3d3c4a2f357235492c216edd98d5c9) bump bridge version 0.2.0 - [`85e3e70`](https://github.com/bitwarden/android/commit/85e3e702a2f7db0be07b841623d4f18e6d1dc021) update bridge CHANGELOG - [`60ad525`](https://github.com/bitwarden/android/commit/60ad52540395b3e0a2e77dd1a28146bb12129a41) revert to 0.1.0 and empty CHANGELOG, holding off for 1.0.0 - [`8ca7123`](https://github.com/bitwarden/android/commit/8ca7123220635f4839dcc9047d37f6cf49160696) newline - [`aaed2fd`](https://github.com/bitwarden/android/commit/aaed2fde4e011e8371131d869a56f330746de5e1) update comment formatting - [`d3191a8`](https://github.com/bitwarden/android/commit/d3191a8752bcb9bcae61d394b52bd4f69c1da7d3) remove return@runCatching - [`af046f9`](https://github.com/bitwarden/android/commit/af046f9ff733328ac565300f1dca6eeae0054b41) rename and move test constants - [`d503887`](https://github.com/bitwarden/android/commit/d50388758efbc76b4fed24611d3c465584e142a3) update test names ### 📊 Changes **4 files changed** (+399 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `bridge/src/main/java/com/bitwarden/bridge/model/AddTotpLoginItemDataJson.kt` (+1 -1) 📝 `bridge/src/main/java/com/bitwarden/bridge/model/SharedAccountDataJson.kt` (+1 -1) ➕ `bridge/src/main/java/com/bitwarden/bridge/util/EncryptionUtils.kt` (+204 -0) ➕ `bridge/src/test/java/com/bitwarden/bridge/util/EncryptionUtilTest.kt` (+193 -0) </details> ### 📄 Description ## 🎟️ Tracking https://livefront.atlassian.net/browse/BITAU-98 ## 📔 Objective The goal of this PR is to set up basic encryption/decryption logic in the Bridge SDK. This will be called by the PMA in future tickets when generating symmetric key, checking symmetric key, and ultimately implementing `BridgeService`. ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:45:24 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4497
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?