github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-09 13:29:18 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2108] [MERGED] SG-687 Request time not updating #44959

New Issue
Closed
opened 2026-04-26 12:11:23 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 12:11:23 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2108
Author: @andrebispo5
Created: 9/30/2022
Status: ✅ Merged
Merged: 10/3/2022
Merged by: @andrebispo5

Base: master ← Head: bugfix/SG-687-request-time

📝 Commits (8)

  • 702a895 [SG-687] request updates text with timer task and expires after 15 mins.
  • 62b55c1 [SG-687] Merge with master.
  • f5e4a38 [SG-697] PR Fixes
  • 72520f0 [SG-687] Ran code format
  • 8e10c2b [SG-687] PR Fixes
  • f559d95 [SG-687] missed constant replacement
  • 66c1709 [SG-687] PR fixes
  • 430103a Merge branch 'master' into bugfix/SG-687-request-time

📊 Changes

3 files changed (+73 additions, -17 deletions)

View changed files

📝 src/App/Pages/Accounts/LoginPasswordlessPage.xaml.cs (+12 -0)
📝 src/App/Pages/Accounts/LoginPasswordlessViewModel.cs (+35 -7)
📝 src/App/Utilities/TimerTask.cs (+26 -10)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

If you wait more than 5 minutes to open the login request, then the “Time” field should say “# minutes ago” instead of “Just now”. However, it still says “Just Now”.

Code changes

Added TaskTimer to update the values with a period of 5 mins. After 15mins the request expires showing a dialog.

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2108 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 9/30/2022 **Status:** ✅ Merged **Merged:** 10/3/2022 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `master` ← **Head:** `bugfix/SG-687-request-time` --- ### 📝 Commits (8) - [`702a895`](https://github.com/bitwarden/android/commit/702a8952fcaae0b42d86488f55aeab54fb55687c) [SG-687] request updates text with timer task and expires after 15 mins. - [`62b55c1`](https://github.com/bitwarden/android/commit/62b55c1f54697b63950c85d382f2a5122bbdbfff) [SG-687] Merge with master. - [`f5e4a38`](https://github.com/bitwarden/android/commit/f5e4a3860fe26b80cfb84123a696bcd68bef2046) [SG-697] PR Fixes - [`72520f0`](https://github.com/bitwarden/android/commit/72520f094edc27efd181c5bdc58ac5278f3a50f4) [SG-687] Ran code format - [`8e10c2b`](https://github.com/bitwarden/android/commit/8e10c2b9526ae4244225322c2ac67342b5c2b029) [SG-687] PR Fixes - [`f559d95`](https://github.com/bitwarden/android/commit/f559d9595fedc2f51fdb4e2651e09e46d8a107f8) [SG-687] missed constant replacement - [`66c1709`](https://github.com/bitwarden/android/commit/66c170981eb20a748f146f94a358a8643fe8699e) [SG-687] PR fixes - [`430103a`](https://github.com/bitwarden/android/commit/430103a14069f724b241dcacfc0bb108a15e05a0) Merge branch 'master' into bugfix/SG-687-request-time ### 📊 Changes **3 files changed** (+73 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/LoginPasswordlessPage.xaml.cs` (+12 -0) 📝 `src/App/Pages/Accounts/LoginPasswordlessViewModel.cs` (+35 -7) 📝 `src/App/Utilities/TimerTask.cs` (+26 -10) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> If you wait more than 5 minutes to open the login request, then the “Time” field should say “# minutes ago” instead of “Just now”. However, it still says “Just Now”. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> Added `TaskTimer` to update the values with a period of 5 mins. After 15mins the request expires showing a dialog. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 12:11:23 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#44959
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?