github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 03:33:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3884] [MERGED] BITAU-164 add no-op version of BridgeService #4493

New Issue
Closed
opened 2025-11-26 23:45:19 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:45:19 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3884
Author: @ahaisting-livefront
Created: 9/9/2024
Status: ✅ Merged
Merged: 9/9/2024
Merged by: @ahaisting-livefront

Base: main ← Head: bridge-service

📝 Commits (4)

  • 25e92bd BITAU-164 add no-op version of BridgeService
  • 2590169 rename BridgeServiceManager -> BridgeServiceProcessor
  • 73df09e move BridgeServiceProcessor and corresponding impl and test to processor package
  • 4b91246 updat name of provides function

📊 Changes

6 files changed (+157 additions, -0 deletions)

View changed files

📝 app/build.gradle.kts (+3 -0)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/di/PlatformManagerModule.kt (+10 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/platform/processor/BridgeServiceProcessor.kt (+14 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/platform/processor/BridgeServiceProcessorImpl.kt (+73 -0)
➕ app/src/main/java/com/x8bit/bitwarden/data/platform/service/BridgeService.kt (+27 -0)
➕ app/src/test/java/com/x8bit/bitwarden/data/platform/processor/BridgeServiceProcessorTest.kt (+30 -0)

📄 Description

🎟️ Tracking

https://livefront.atlassian.net/browse/BITAU-164

📔 Objective

The goal of this PR is to set up a no-op BridgeService that is returned whenever the feature flag for authenticator sync is turned of.

📸 Screenshots

N/A

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3884 **Author:** [@ahaisting-livefront](https://github.com/ahaisting-livefront) **Created:** 9/9/2024 **Status:** ✅ Merged **Merged:** 9/9/2024 **Merged by:** [@ahaisting-livefront](https://github.com/ahaisting-livefront) **Base:** `main` ← **Head:** `bridge-service` --- ### 📝 Commits (4) - [`25e92bd`](https://github.com/bitwarden/android/commit/25e92bdd949661800f2be94f0817c2f1e9d41c39) BITAU-164 add no-op version of BridgeService - [`2590169`](https://github.com/bitwarden/android/commit/2590169fc877c149894b6c7570917ee2dd0e6534) rename BridgeServiceManager -> BridgeServiceProcessor - [`73df09e`](https://github.com/bitwarden/android/commit/73df09e57e00fb94c88b4ca77e8d789a068ba490) move BridgeServiceProcessor and corresponding impl and test to processor package - [`4b91246`](https://github.com/bitwarden/android/commit/4b91246e61dc934ab36b2fdfa37101349f392bc2) updat name of provides function ### 📊 Changes **6 files changed** (+157 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `app/build.gradle.kts` (+3 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/di/PlatformManagerModule.kt` (+10 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/platform/processor/BridgeServiceProcessor.kt` (+14 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/platform/processor/BridgeServiceProcessorImpl.kt` (+73 -0) ➕ `app/src/main/java/com/x8bit/bitwarden/data/platform/service/BridgeService.kt` (+27 -0) ➕ `app/src/test/java/com/x8bit/bitwarden/data/platform/processor/BridgeServiceProcessorTest.kt` (+30 -0) </details> ### 📄 Description ## 🎟️ Tracking https://livefront.atlassian.net/browse/BITAU-164 ## 📔 Objective The goal of this PR is to set up a no-op `BridgeService` that is returned whenever the feature flag for authenticator sync is turned of. ## 📸 Screenshots N/A ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:45:19 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4493
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?