github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 21:10:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2031] [MERGED] [PS-1252] Fix Content Type for file upload #44908

New Issue
Closed
opened 2026-04-26 12:08:15 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 12:08:15 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2031
Author: @alex-martel
Created: 8/5/2022
Status: ✅ Merged
Merged: 8/26/2022
Merged by: @aj-rosado

Base: master ← Head: fixContentTypeFileUpload

📝 Commits (1)

  • 4b52c88 Fix Content Type for file upload

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 src/Core/Services/BitwardenFileUploadService.cs (+3 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fixes https://github.com/bitwarden/mobile/issues/2018

Code changes

  • **BitwardenFileUploadService.cs ** Sets the content-type of the data/file upload to application/octet-stream to be consistent with other bitwarden client.

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2031 **Author:** [@alex-martel](https://github.com/alex-martel) **Created:** 8/5/2022 **Status:** ✅ Merged **Merged:** 8/26/2022 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `master` ← **Head:** `fixContentTypeFileUpload` --- ### 📝 Commits (1) - [`4b52c88`](https://github.com/bitwarden/android/commit/4b52c88f4bcf5236bc7c29d13c713f793da99f7c) Fix Content Type for file upload ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Services/BitwardenFileUploadService.cs` (+3 -1) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Fixes https://github.com/bitwarden/mobile/issues/2018 ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **BitwardenFileUploadService.cs ** Sets the content-type of the data/file upload to application/octet-stream to be consistent with other bitwarden client. ## Before you submit - [x] I have checked for formatting errors (`dotnet tool run dotnet-format --check`) (required) - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 12:08:15 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#44908
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?