github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-11 09:06:13 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #1809] [MERGED] Changed links on Settings "Change Master Password" and "Two Step Login" #44747

New Issue
Closed
opened 2026-04-26 11:58:55 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 11:58:55 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1809
Author: @fedemkr
Created: 2/23/2022
Status: ✅ Merged
Merged: 2/24/2022
Merged by: @fedemkr

Base: master ← Head: ux/update-settings-web-links

📝 Commits (1)

  • 1fb798a Changed link on Settings "Change Master Password" and "Two Step Login" to go to the web vault settings. Also refactored a bit to reuse the urls

📊 Changes

6 files changed (+28 additions, -29 deletions)

View changed files

📝 src/App/Pages/Accounts/LockPageViewModel.cs (+1 -1)
📝 src/App/Pages/CaptchaProtectedViewModel.cs (+5 -7)
📝 src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs (+3 -8)
📝 src/App/Utilities/AppHelpers.cs (+1 -6)
📝 src/Core/Abstractions/IEnvironmentService.cs (+2 -1)
📝 src/Core/Services/EnvironmentService.cs (+16 -6)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Change link on Settings "Change Master Password" and "Two-Step Login" to go to Web Vault Settings.

Code changes

  • EnvironmentService.cs: Added constants for default Web Vault and Snd url and refactored a bit the code to use them and also added a new method to get the web url for Send.
  • SettingsPageViewModel.cs: Changed the url on "Change Master Password" and "Two-Step Login" to go to the Web Vault Settings
  • Others: Adapted to the new EnvironmentService

Testing requirements

For any of the testing, take into consideration that the web url is different depending on what is configured, the precedence is as follows:

Mainly

Test that when clicking on Settings > Change Master Password and Settings > Two-Step Login the user is redirected to the web vault login (in fact, it should go to the web vault settings after login but deep linking is not implemented on the web yet, so it will just land the user on the login)

Secondary

I changed some things on the EnvironmentService that were being used, so just in case we should check that they are still working:

  • On Lock screen, the text should indicate on which host the user is logged in
  • The Captcha should load correctly when logging in
  • On Settings, the Web Vault should still redirect to the webpage of the web vault
  • Share link should keep working when Copying/Sharing it

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1809 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 2/23/2022 **Status:** ✅ Merged **Merged:** 2/24/2022 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `ux/update-settings-web-links` --- ### 📝 Commits (1) - [`1fb798a`](https://github.com/bitwarden/android/commit/1fb798a880c34153974f0e66700b88e4ede80bd7) Changed link on Settings "Change Master Password" and "Two Step Login" to go to the web vault settings. Also refactored a bit to reuse the urls ### 📊 Changes **6 files changed** (+28 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/LockPageViewModel.cs` (+1 -1) 📝 `src/App/Pages/CaptchaProtectedViewModel.cs` (+5 -7) 📝 `src/App/Pages/Settings/SettingsPage/SettingsPageViewModel.cs` (+3 -8) 📝 `src/App/Utilities/AppHelpers.cs` (+1 -6) 📝 `src/Core/Abstractions/IEnvironmentService.cs` (+2 -1) 📝 `src/Core/Services/EnvironmentService.cs` (+16 -6) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Change link on Settings "Change Master Password" and "Two-Step Login" to go to Web Vault Settings. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **EnvironmentService.cs:** Added constants for default Web Vault and Snd url and refactored a bit the code to use them and also added a new method to get the web url for Send. * **SettingsPageViewModel.cs:** Changed the url on "Change Master Password" and "Two-Step Login" to go to the Web Vault Settings * **Others:** Adapted to the new `EnvironmentService` ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> For any of the testing, take into consideration that the web url is different depending on what is configured, the precedence is as follows: - Web Vault Server URL - Self-hosted Environment -> Server URL - Default (https://vault.bitwarden.com) ### Mainly Test that when clicking on **Settings > Change Master Password** and **Settings > Two-Step Login** the user is redirected to the web vault login (in fact, it should go to the web vault settings after login but deep linking is not implemented on the web yet, so it will just land the user on the login) ### Secondary I changed some things on the `EnvironmentService` that were being used, so just in case we should check that they are still working: - On Lock screen, the text should indicate on which host the user is logged in - The Captcha should load correctly when logging in - On Settings, the Web Vault should still redirect to the webpage of the web vault - Share link should keep working when Copying/Sharing it ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 11:58:55 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#44747
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?