github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-10 05:49:44 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #1808] [MERGED] Take environment into account when checking for existing account #44746

New Issue
Closed
opened 2026-04-26 11:58:53 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 11:58:53 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1808
Author: @mpbw2
Created: 2/23/2022
Status: ✅ Merged
Merged: 2/23/2022
Merged by: @mpbw2

Base: master ← Head: bugfix-accountcheck

📝 Commits (1)

  • 899a125 take environment into account when checking for existing account

📊 Changes

1 file changed (+16 additions, -7 deletions)

View changed files

📝 src/App/Pages/Accounts/LoginPageViewModel.cs (+16 -7)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

When checking for an already logged-in account, take the environment into account (otherwise identical emails can't be used across different servers)

Code changes

  • LoginPageViewModel.cs: Added BaseUrl comparison to existing account check, and moved switch prompt dialog to dedicated method

Testing requirements

https://app.asana.com/0/1201803072708593/1201873026592841

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1808 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 2/23/2022 **Status:** ✅ Merged **Merged:** 2/23/2022 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `bugfix-accountcheck` --- ### 📝 Commits (1) - [`899a125`](https://github.com/bitwarden/android/commit/899a1252a95a4a640fa8daf707514220085cb8a6) take environment into account when checking for existing account ### 📊 Changes **1 file changed** (+16 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/LoginPageViewModel.cs` (+16 -7) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> When checking for an already logged-in account, take the environment into account (otherwise identical emails can't be used across different servers) ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **LoginPageViewModel.cs:** Added `BaseUrl` comparison to existing account check, and moved switch prompt dialog to dedicated method ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> https://app.asana.com/0/1201803072708593/1201873026592841 ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 11:58:53 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#44746
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?