github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-19 05:02:48 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3853] [MERGED] [PM-10930] Fix password generator policies #4469

New Issue
Closed
opened 2025-11-26 23:44:54 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:44:54 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3853
Author: @aj-rosado
Created: 9/3/2024
Status: ✅ Merged
Merged: 9/10/2024
Merged by: @aj-rosado

Base: main ← Head: PM-10930/fix-password-generator-policies

📝 Commits (8)

  • c558399 updated isOrganizationExemptFromPolicies to return false on PolicyTypeJson.PasswordGenerator
  • e0ec1ae added Json settings on SyncResponseJsonExtensions
  • 4007d75 Simplified json instance on SyncResponseJsonExtensions and removed unnecessary ; on PolicyManagaerImpl
  • e7afcff optimized imports
  • e16b9d9 Added explicitNulls on json settings
  • ea4f2ec moved json to top level on SyncResponseJsonExtensions
  • b7c6ae8 renaming top level variable json to JSON
  • dcc0980 Merge branch 'main' into PM-10930/fix-password-generator-policies

📊 Changes

3 files changed (+40 additions, -4 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/auth/repository/util/SyncResponseJsonExtensions.kt (+10 -4)
📝 app/src/main/java/com/x8bit/bitwarden/data/platform/manager/PolicyManagerImpl.kt (+2 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/platform/manager/PolicyManagerTest.kt (+28 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-10930

📔 Objective

This aims to fix two issues on the PasswordGenerator. Add settings to json on SyncResponseJson.Policy.policyInformation as ignoreUnknownKeys as false is causing this.

Also not allowing PolicyTypeJson.PASSWORD_GENERATOR types to have users exempt from policies.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3853 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 9/3/2024 **Status:** ✅ Merged **Merged:** 9/10/2024 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `main` ← **Head:** `PM-10930/fix-password-generator-policies` --- ### 📝 Commits (8) - [`c558399`](https://github.com/bitwarden/android/commit/c5583994fa9be7e2363333f4dad23889c9075fb0) updated isOrganizationExemptFromPolicies to return false on PolicyTypeJson.PasswordGenerator - [`e0ec1ae`](https://github.com/bitwarden/android/commit/e0ec1ae42d8314b1ab1ade846eb9952a517f12fb) added Json settings on SyncResponseJsonExtensions - [`4007d75`](https://github.com/bitwarden/android/commit/4007d75f2c72845c638ba7ca679374dd8341b83b) Simplified json instance on SyncResponseJsonExtensions and removed unnecessary ; on PolicyManagaerImpl - [`e7afcff`](https://github.com/bitwarden/android/commit/e7afcff819c357f81bd0c092f9f23402b349773a) optimized imports - [`e16b9d9`](https://github.com/bitwarden/android/commit/e16b9d915f560c1b924d2a7f068c16eada4b9d17) Added explicitNulls on json settings - [`ea4f2ec`](https://github.com/bitwarden/android/commit/ea4f2ecd6986e20074444b1f095c4d507107782b) moved json to top level on SyncResponseJsonExtensions - [`b7c6ae8`](https://github.com/bitwarden/android/commit/b7c6ae8bfa367fb257988011ce06c15b086698c1) renaming top level variable json to JSON - [`dcc0980`](https://github.com/bitwarden/android/commit/dcc09800d8cd41a902d09ff8dd8d914704325511) Merge branch 'main' into PM-10930/fix-password-generator-policies ### 📊 Changes **3 files changed** (+40 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/util/SyncResponseJsonExtensions.kt` (+10 -4) 📝 `app/src/main/java/com/x8bit/bitwarden/data/platform/manager/PolicyManagerImpl.kt` (+2 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/platform/manager/PolicyManagerTest.kt` (+28 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-10930 ## 📔 Objective This aims to fix two issues on the PasswordGenerator. Add settings to json on `SyncResponseJson.Policy.policyInformation` as `ignoreUnknownKeys` as false is causing this. Also not allowing `PolicyTypeJson.PASSWORD_GENERATOR` types to have users exempt from policies. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:44:54 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4469
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?