github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-09 13:29:18 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #1656] [MERGED] [Key Connector] Hide MP input in iOS extensions #44636

New Issue
Closed
opened 2026-04-26 11:52:09 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 11:52:09 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1656
Author: @eliykat
Created: 11/22/2021
Status: ✅ Merged
Merged: 11/22/2021
Merged by: @eliykat

Base: master ← Head: keyconnector/iOS-hide-mp

📝 Commits (3)

  • 6faf78c Hide MP on iOS unlock screen
  • b75a539 Update navbar if using biometric auth only
  • e82343a Tidy up logic

📊 Changes

1 file changed (+88 additions, -40 deletions)

View changed files

📝 src/iOS.Core/Controllers/LockPasswordViewController.cs (+88 -40)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Implements https://github.com/bitwarden/mobile/pull/1654 for the iOS extension & autofill projects:

If a key connector user has biometrics set up on the lock screen, we want to hide the master password prompt. [...]

If the user is using a PIN with biometrics, the screen should remain the same and prompt for PIN input.

Code changes

  • src/iOS.Core/Controllers/LockPasswordViewController.cs:
    • hide the Submit button if using biometric unlock only (this is done by setting text to null and disabling it)
    • change the title text to "Unlock Vault" if using biometric unlock only
    • skip setup for the MasterPasswordCell if using biometric unlock only
    • if using biometric unlock only, move the "biometric cell" up to the first row, and adjust the length of the grid accordingly. To assist this, I've extracted the 'builder' logic for the biometric cell into a getter.

Please pay particular attention to the conditional logic involved - there are quite a few different combinations, and I'd like simpler logic, but I think this works.

Screenshots

Screen Shot 2021-11-22 at 2 04 39 pm

Testing requirements

  • confirm that the iOS unlock page conforms to the Figma and behaves as expected
  • full regression on iOS extension ("share") and autofill unlock page, especially with different combinations. e.g. MP only, MP + biometric, PIN only, PIN + biometric, biometric only.

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1656 **Author:** [@eliykat](https://github.com/eliykat) **Created:** 11/22/2021 **Status:** ✅ Merged **Merged:** 11/22/2021 **Merged by:** [@eliykat](https://github.com/eliykat) **Base:** `master` ← **Head:** `keyconnector/iOS-hide-mp` --- ### 📝 Commits (3) - [`6faf78c`](https://github.com/bitwarden/android/commit/6faf78c1aa188193ef16b19bda58a846c8f642ba) Hide MP on iOS unlock screen - [`b75a539`](https://github.com/bitwarden/android/commit/b75a539d5d6f6118ecc7ce33854ae069bcde00ff) Update navbar if using biometric auth only - [`e82343a`](https://github.com/bitwarden/android/commit/e82343a5fbaa1f6d407f280e9729b44f2647edae) Tidy up logic ### 📊 Changes **1 file changed** (+88 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `src/iOS.Core/Controllers/LockPasswordViewController.cs` (+88 -40) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [x] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Implements https://github.com/bitwarden/mobile/pull/1654 for the iOS extension & autofill projects: > If a key connector user has biometrics set up on the lock screen, we want to hide the master password prompt. [...] > > If the user is using a PIN with biometrics, the screen should remain the same and prompt for PIN input. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **src/iOS.Core/Controllers/LockPasswordViewController.cs**: * hide the Submit button if using biometric unlock only (this is done by setting text to `null` and disabling it) * change the title text to "Unlock Vault" if using biometric unlock only * skip setup for the `MasterPasswordCell` if using biometric unlock only * if using biometric unlock only, move the "biometric cell" up to the first row, and adjust the length of the grid accordingly. To assist this, I've extracted the 'builder' logic for the biometric cell into a getter. Please pay particular attention to the conditional logic involved - there are quite a few different combinations, and I'd like simpler logic, but I think this works. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> <img width="561" alt="Screen Shot 2021-11-22 at 2 04 39 pm" src="https://user-images.githubusercontent.com/31796059/142799506-bb24feef-28f6-4725-93b0-8e4ca8fb54b5.png"> ## Testing requirements <!--What functionality requires testing by QA? This includes testing new behavior and regression testing--> * confirm that the iOS unlock page conforms to the Figma and behaves as expected * full regression on iOS extension ("share") and autofill unlock page, especially with different combinations. e.g. MP only, MP + biometric, PIN only, PIN + biometric, biometric only. ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 11:52:09 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#44636
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?