github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 20:41:29 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #3842] [MERGED] PM-11387 on new create account with email verification, attempt login… #4459

New Issue
Closed
opened 2025-11-26 23:44:46 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:44:46 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3842
Author: @dseverns-livefront
Created: 8/28/2024
Status: ✅ Merged
Merged: 8/29/2024
Merged by: @dseverns-livefront

Base: main ← Head: PM-11387/login-after-account-creation

📝 Commits (4)

  • 447cbf3 PM-11387 on new create account with email verification, attempt login/unlock vault after successful registration
  • c130dbf feedback
  • 74a4a4a english is only my first language not my 0th
  • 9dfa7d2 clear dialog in its own fun

📊 Changes

5 files changed (+167 additions, -93 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationNavigation.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationScreen.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt (+61 -17)
📝 app/src/main/res/values/strings.xml (+1 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModelTest.kt (+103 -74)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-11387

📔 Objective

  • with the new create account through email verification we want to attempt logging in after the account is successfully created.
  • If the login attempt is successful state based navigation takes over, currently takes user to the vault, in the future new onboarding flow.
  • If the account is created, but the login attempt fails the user will land on the login with the MP page.
  • Shows a toast once the account is created to provide feedback to the user.
  • Went with approach of going through the ViewModel, advantage is that its already behind the feature flag and keeps the existing logic unchanged in the repository as well as allows for separate handling of the Register and Login results.

📸 Screenshots

Login Succeeds Login Fails
https://github.com/user-attachments/assets/cb60a8bf-5e10-4152-b33a-419b81064ed8 https://github.com/user-attachments/assets/f177e5fa-a793-4859-8047-51288f482298

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3842 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 8/28/2024 **Status:** ✅ Merged **Merged:** 8/29/2024 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `PM-11387/login-after-account-creation` --- ### 📝 Commits (4) - [`447cbf3`](https://github.com/bitwarden/android/commit/447cbf3cf9307b4b664d57b8dc0c5fd35c953391) PM-11387 on new create account with email verification, attempt login/unlock vault after successful registration - [`c130dbf`](https://github.com/bitwarden/android/commit/c130dbf47f30024f8225c5f63f12492a3776e67c) feedback - [`74a4a4a`](https://github.com/bitwarden/android/commit/74a4a4a162957de15bb0fe4b997464f2c1695d03) english is only my first language not my 0th - [`9dfa7d2`](https://github.com/bitwarden/android/commit/9dfa7d26e27ded4736c1349abb97e5696df882bf) clear dialog in its own fun ### 📊 Changes **5 files changed** (+167 additions, -93 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationNavigation.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationScreen.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt` (+61 -17) 📝 `app/src/main/res/values/strings.xml` (+1 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModelTest.kt` (+103 -74) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-11387 <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective - with the new create account through email verification we want to attempt logging in after the account is successfully created. - If the login attempt is successful state based navigation takes over, currently takes user to the vault, in the future new onboarding flow. - If the account is created, but the login attempt fails the user will land on the login with the MP page. - Shows a toast once the account is created to provide feedback to the user. - Went with approach of going through the ViewModel, advantage is that its already behind the feature flag and keeps the existing logic unchanged in the repository as well as allows for separate handling of the Register and Login results. <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots | Login Succeeds | Login Fails | |--------|--------| | https://github.com/user-attachments/assets/cb60a8bf-5e10-4152-b33a-419b81064ed8 | https://github.com/user-attachments/assets/f177e5fa-a793-4859-8047-51288f482298 | <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:44:46 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4459
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?