github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 14:16:23 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3840] [MERGED] [PM-11398] [PM-10872] - Fix: Search fields not showing text correctly #4457

New Issue
Closed
opened 2025-11-26 23:44:44 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:44:44 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3840
Author: @mathiasmader
Created: 8/27/2024
Status: ✅ Merged
Merged: 9/3/2024
Merged by: @SaintPatrck

Base: main ← Head: main

📝 Commits (4)

  • 588935b fix: change to searchBar to singleLine
  • 7ef0665 Merge branch 'bitwarden:main' into main
  • 62c51a0 chore(appbar): suppress LongMethod warning in BitwardenSearchTopAppBar
  • 0826296 Merge branch 'bitwarden:main' into main

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/components/appbar/BitwardenSearchTopAppBar.kt (+2 -0)

📄 Description

🎟️ Tracking

PM-10872 - #3725

📔 Objective

make searchbar singleLine

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3840 **Author:** [@mathiasmader](https://github.com/mathiasmader) **Created:** 8/27/2024 **Status:** ✅ Merged **Merged:** 9/3/2024 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (4) - [`588935b`](https://github.com/bitwarden/android/commit/588935b6121cc8973e5999462f547e7587cd01f1) fix: change to searchBar to singleLine - [`7ef0665`](https://github.com/bitwarden/android/commit/7ef0665cab497b50d22944bfab2f9485099b457c) Merge branch 'bitwarden:main' into main - [`62c51a0`](https://github.com/bitwarden/android/commit/62c51a0d677df8a277ad7601a74c77112c5f3a5f) chore(appbar): suppress LongMethod warning in BitwardenSearchTopAppBar - [`0826296`](https://github.com/bitwarden/android/commit/08262961e9cf88ac7965162d6aca51d68d799625) Merge branch 'bitwarden:main' into main ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/appbar/BitwardenSearchTopAppBar.kt` (+2 -0) </details> ### 📄 Description ## 🎟️ Tracking [PM-10872] - #3725 ## 📔 Objective make searchbar singleLine ## 📸 Screenshots ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-10872]: https://bitwarden.atlassian.net/browse/PM-10872?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:44:44 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4457
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?