github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 13:44:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3835] [MERGED] PM-11354: TDE unlock since we already have the correct key from the identity service #4454

New Issue
Closed
opened 2025-11-26 23:44:41 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:44:41 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3835
Author: @david-livefront
Created: 8/26/2024
Status: ✅ Merged
Merged: 8/27/2024
Merged by: @david-livefront

Base: main ← Head: PM-11354-password-unlock-after-tde-unlock

📝 Commits (1)

  • 08e2f91 PM-11354: We should not store the user key after a TDE unlock since we already have the correct key from the identity service

📊 Changes

2 files changed (+0 additions, -5 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt (+0 -1)
📝 app/src/test/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt (+0 -4)

📄 Description

🎟️ Tracking

PM-11354

📔 Objective

This PR removes the logic to store the user key after completing a login with TDE. The asymmetricalKey that we have at that point is not the correct key to store and it causes errors when unlocking the vault with a password. The real userKey is already stored from the identity response and does allow the user to login via password.

📸 Screenshots

Before After

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3835 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 8/26/2024 **Status:** ✅ Merged **Merged:** 8/27/2024 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `PM-11354-password-unlock-after-tde-unlock` --- ### 📝 Commits (1) - [`08e2f91`](https://github.com/bitwarden/android/commit/08e2f9138314fa26ffef8f71efa165bbb1c4b248) PM-11354: We should not store the user key after a TDE unlock since we already have the correct key from the identity service ### 📊 Changes **2 files changed** (+0 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt` (+0 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt` (+0 -4) </details> ### 📄 Description ## 🎟️ Tracking [PM-11354](https://bitwarden.atlassian.net/browse/PM-11354) ## 📔 Objective This PR removes the logic to store the user key after completing a login with TDE. The `asymmetricalKey` that we have at that point is not the correct key to store and it causes errors when unlocking the vault with a password. The real `userKey` is already stored from the identity response and does allow the user to login via password. ## 📸 Screenshots | Before | After | | --- | --- | | <video src="https://github.com/user-attachments/assets/2a2d35a0-605f-4821-81f5-755dc2b85066" width="300" /> | <video src="https://github.com/user-attachments/assets/6a5f3661-aaaa-4d9d-b2fc-21b051bf1b9d" width="300" /> | ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-11354]: https://bitwarden.atlassian.net/browse/PM-11354?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:44:41 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4454
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?