github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-19 05:02:48 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3829] [MERGED] [PM-10762] Remove Passkey button should be hidden when I have Can View permission #4448

New Issue
Closed
opened 2025-11-26 23:44:37 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:44:37 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3829
Author: @LRNcardozoWDF
Created: 8/26/2024
Status: ✅ Merged
Merged: 8/29/2024
Merged by: @LRNcardozoWDF

Base: main ← Head: PM-10762-Remove-passkey-button-hidden-with-can-view-permission

📝 Commits (9)

  • 6d225e2 PM-9833 Add canEdit to model
  • b72acfa Merge branch 'main' into PM-10762-Remove-passkey-button-hidden-with-can-view-permission
  • bfaeb29 Merge branch 'main' into PM-10762-Remove-passkey-button-hidden-with-can-view-permission
  • 9c9c028 Merge branch 'main' into PM-10762-Remove-passkey-button-hidden-with-can-view-permission
  • f847aca Merge branch 'main' into PM-10762-Remove-passkey-button-hidden-with-can-view-permission
  • c5f95fd Merge branch 'main' into PM-10762-Remove-passkey-button-hidden-with-can-view-permission
  • 94335eb PM-10762 Added docs for canEdit
  • a4f1bfb PM-10762 Fix PR comments
  • 539b918 Merge branch 'main' into PM-10762-Remove-passkey-button-hidden-with-can-view-permission

📊 Changes

6 files changed (+35 additions, -3 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditLoginItems.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt (+7 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/util/CipherViewExtensions.kt (+1 -0)
📝 app/src/test/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/CipherViewUtil.kt (+1 -1)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreenTest.kt (+24 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/util/CipherViewExtensionsTest.kt (+1 -1)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-10762

📔 Objective

Initially we weren't hiding the remove Passkey button when the user has Can View permission, this also hides the button for that case.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3829 **Author:** [@LRNcardozoWDF](https://github.com/LRNcardozoWDF) **Created:** 8/26/2024 **Status:** ✅ Merged **Merged:** 8/29/2024 **Merged by:** [@LRNcardozoWDF](https://github.com/LRNcardozoWDF) **Base:** `main` ← **Head:** `PM-10762-Remove-passkey-button-hidden-with-can-view-permission` --- ### 📝 Commits (9) - [`6d225e2`](https://github.com/bitwarden/android/commit/6d225e2120c2268b05a04d01b255861e356bfe14) PM-9833 Add canEdit to model - [`b72acfa`](https://github.com/bitwarden/android/commit/b72acfa83fcd8002aea3899566d65290b6ece01a) Merge branch 'main' into PM-10762-Remove-passkey-button-hidden-with-can-view-permission - [`bfaeb29`](https://github.com/bitwarden/android/commit/bfaeb29203d0ac6c02814c02fb4e97fb7f2013cc) Merge branch 'main' into PM-10762-Remove-passkey-button-hidden-with-can-view-permission - [`9c9c028`](https://github.com/bitwarden/android/commit/9c9c0284245b0bd91035bfcd0784dee35b55e14c) Merge branch 'main' into PM-10762-Remove-passkey-button-hidden-with-can-view-permission - [`f847aca`](https://github.com/bitwarden/android/commit/f847acacbf04d5bf77013ceab1647f210d8465c9) Merge branch 'main' into PM-10762-Remove-passkey-button-hidden-with-can-view-permission - [`c5f95fd`](https://github.com/bitwarden/android/commit/c5f95fd3f07f82a0fd4acce40d3953e9331155bb) Merge branch 'main' into PM-10762-Remove-passkey-button-hidden-with-can-view-permission - [`94335eb`](https://github.com/bitwarden/android/commit/94335ebfbeebca68844b4f930e2481c4fed9193c) PM-10762 Added docs for canEdit - [`a4f1bfb`](https://github.com/bitwarden/android/commit/a4f1bfbead18577190e5132f659fc3bfb7e3f48b) PM-10762 Fix PR comments - [`539b918`](https://github.com/bitwarden/android/commit/539b918ce0ddbc7b6582456d2d123bdcd137f059) Merge branch 'main' into PM-10762-Remove-passkey-button-hidden-with-can-view-permission ### 📊 Changes **6 files changed** (+35 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditLoginItems.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditViewModel.kt` (+7 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/vault/feature/addedit/util/CipherViewExtensions.kt` (+1 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/data/vault/datasource/sdk/model/CipherViewUtil.kt` (+1 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/VaultAddEditScreenTest.kt` (+24 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/vault/feature/addedit/util/CipherViewExtensionsTest.kt` (+1 -1) </details> ### 📄 Description ## 🎟️ Tracking <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> https://bitwarden.atlassian.net/browse/PM-10762 ## 📔 Objective <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> Initially we weren't hiding the remove Passkey button when the user has `Can View` permission, this also hides the button for that case. ## 📸 Screenshots <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:44:37 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4448
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?