github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-18 03:09:11 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3821] [MERGED] [PM-11307] Fix typo in method name: shouldShouldRequestPermissionRationale #4444

New Issue
Closed
opened 2025-11-26 23:44:33 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:44:33 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3821
Author: @geek5nan
Created: 8/23/2024
Status: ✅ Merged
Merged: 8/26/2024
Merged by: @SaintPatrck

Base: main ← Head: fix-typo

📝 Commits (1)

  • 309292a Fix typo in method name: shouldShouldRequestPermissionRationale -> shouldShowRequestPermissionRationale

📊 Changes

3 files changed (+3 additions, -3 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/permissions/PermissionsManager.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/permissions/PermissionsManagerImpl.kt (+1 -1)
📝 app/src/test/java/com/x8bit/bitwarden/ui/platform/manager/permissions/FakePermissionManager.kt (+1 -1)

📄 Description

Summary

This PR addresses a typo in the codebase where the method shouldShowRequestPermissionRationale was incorrectly named as shouldShouldRequestPermissionRationale.

Details

  • Renamed the method shouldShouldRequestPermissionRationale to the correct name shouldShowRequestPermissionRationale.
  • Updated all instances where the incorrect method name was used.

Impact

This change should improve code readability and prevent any potential confusion or errors related to this method.

Thank you for your consideration!

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3821 **Author:** [@geek5nan](https://github.com/geek5nan) **Created:** 8/23/2024 **Status:** ✅ Merged **Merged:** 8/26/2024 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `fix-typo` --- ### 📝 Commits (1) - [`309292a`](https://github.com/bitwarden/android/commit/309292a4151deef4fc59165f7b645389e20f2f6c) Fix typo in method name: shouldShouldRequestPermissionRationale -> shouldShowRequestPermissionRationale ### 📊 Changes **3 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/permissions/PermissionsManager.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/manager/permissions/PermissionsManagerImpl.kt` (+1 -1) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/platform/manager/permissions/FakePermissionManager.kt` (+1 -1) </details> ### 📄 Description ### Summary This PR addresses a typo in the codebase where the method `shouldShowRequestPermissionRationale` was incorrectly named as `shouldShouldRequestPermissionRationale`. ### Details - Renamed the method `shouldShouldRequestPermissionRationale` to the correct name `shouldShowRequestPermissionRationale`. - Updated all instances where the incorrect method name was used. ### Impact This change should improve code readability and prevent any potential confusion or errors related to this method. Thank you for your consideration! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:44:33 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4444
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?