github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-10 16:45:43 -05:00
Code Issues 1.1k Packages Projects Releases 124 Wiki Activity

[PR #1065] [MERGED] fix for passphrase generator persistent settings #44328

New Issue
Closed
opened 2026-04-26 11:34:10 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 11:34:10 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1065
Author: @mpbw2
Created: 9/10/2020
Status: ✅ Merged
Merged: 9/10/2020
Merged by: @mpbw2

Base: master ← Head: bugfix-generator

📝 Commits (1)

  • 3e23bfd fix for passphrase generator persistent settings

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 src/App/Pages/Generator/GeneratorPageViewModel.cs (+4 -0)

📄 Description

Upon page creation, SliderInputAsync() was firing before InitAsync() which would overwrite any existing settings with defaults before the previously saved values could be loaded. Simply blocking this by checking _doneIniting allows the saved values to be loaded first. Fixes #1059

Edit: Clarification - I should say InitAsync() is actually called first, but it calls LoadFromOptions() which sets Length which in turn calls SliderInputAsync() before InitAsync() is truly finished. At the moment this happens there are two values which have not yet been loaded from options. Which values? You guessed it - Capitalize and IncludeNumber from the passphrase generator page.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1065 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 9/10/2020 **Status:** ✅ Merged **Merged:** 9/10/2020 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `bugfix-generator` --- ### 📝 Commits (1) - [`3e23bfd`](https://github.com/bitwarden/android/commit/3e23bfd6af887ede53e0458a2c38658ea3207716) fix for passphrase generator persistent settings ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Generator/GeneratorPageViewModel.cs` (+4 -0) </details> ### 📄 Description Upon page creation, `SliderInputAsync()` was firing before `InitAsync()` which would overwrite any existing settings with defaults before the previously saved values could be loaded. Simply blocking this by checking `_doneIniting` allows the saved values to be loaded first. Fixes #1059 Edit: Clarification - I should say `InitAsync()` is actually called first, but it calls `LoadFromOptions()` which sets `Length` which in turn calls `SliderInputAsync()` before `InitAsync()` is truly finished. At the moment this happens there are two values which have not yet been loaded from options. Which values? You guessed it - `Capitalize` and `IncludeNumber` from the passphrase generator page. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 11:34:10 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#44328
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?