github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3793] [MERGED] PM-10617 modify pw strength indicator to show min chars if required. #4424

New Issue
Closed
opened 2025-11-26 23:44:18 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:44:18 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3793
Author: @dseverns-livefront
Created: 8/20/2024
Status: ✅ Merged
Merged: 8/22/2024
Merged by: @dseverns-livefront

Base: main ← Head: PM-10617/add-char-to-pw-strength

📝 Commits (9)

  • f97d57d PM-10617 update complete registration screen to match new onboarding spec. Add feature flag check for what to do once account registered.
  • d22a38e feedback
  • 43fe931 PM-10617 modify pw strength indicator to show min chars if required.
  • 9188510 resources
  • 8ce7f7a fix test
  • 2f3155e Add test for conditional text
  • 66915aa resolve conflicts after rebase
  • ef82391 clean up
  • e27ae64 remove unneeded test

📊 Changes

10 files changed (+184 additions, -5 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationScreen.kt (+6 -3)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt (+2 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/PasswordStrengthIndicator.kt (+105 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountScreen.kt (+1 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/exportvault/ExportVaultScreen.kt (+1 -0)
➕ app/src/main/res/drawable/ic_circle.xml (+11 -0)
➕ app/src/main/res/drawable/ic_plain_checkmark.xml (+13 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationScreenTest.kt (+1 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModelTest.kt (+2 -0)
➕ app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/PasswordStrengthIndicatorTest.kt (+42 -0)

📄 Description

Builds of #3787 just wanted to break that up since I was modifying some shared code.

https://github.com/user-attachments/assets/0a6c656b-8ccd-4ea2-b4f4-67b1856b7679

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3793 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 8/20/2024 **Status:** ✅ Merged **Merged:** 8/22/2024 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `PM-10617/add-char-to-pw-strength` --- ### 📝 Commits (9) - [`f97d57d`](https://github.com/bitwarden/android/commit/f97d57d48ee9bcce8794459dde3c5e493df95021) PM-10617 update complete registration screen to match new onboarding spec. Add feature flag check for what to do once account registered. - [`d22a38e`](https://github.com/bitwarden/android/commit/d22a38e9f56c2dbc09544259a68efc093978edf3) feedback - [`43fe931`](https://github.com/bitwarden/android/commit/43fe931ba7d62086ae22c7d3749ddac44f29efec) PM-10617 modify pw strength indicator to show min chars if required. - [`9188510`](https://github.com/bitwarden/android/commit/91885106074b86a977276a28d47fe5541a82ca67) resources - [`8ce7f7a`](https://github.com/bitwarden/android/commit/8ce7f7af24079ecca9117c63e0caa512d97f7cf0) fix test - [`2f3155e`](https://github.com/bitwarden/android/commit/2f3155ec4f18539b7763c66258d8e09942b7610c) Add test for conditional text - [`66915aa`](https://github.com/bitwarden/android/commit/66915aa1e6b3c1bb2c2c0c0a5c0f22e18af55a8d) resolve conflicts after rebase - [`ef82391`](https://github.com/bitwarden/android/commit/ef82391a9b08affaed7ff93df257ea12f4b0a6f4) clean up - [`e27ae64`](https://github.com/bitwarden/android/commit/e27ae64bd48c0f632a2db23f02c47def9cf4fa0c) remove unneeded test ### 📊 Changes **10 files changed** (+184 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationScreen.kt` (+6 -3) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt` (+2 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/PasswordStrengthIndicator.kt` (+105 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountScreen.kt` (+1 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/platform/feature/settings/exportvault/ExportVaultScreen.kt` (+1 -0) ➕ `app/src/main/res/drawable/ic_circle.xml` (+11 -0) ➕ `app/src/main/res/drawable/ic_plain_checkmark.xml` (+13 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationScreenTest.kt` (+1 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModelTest.kt` (+2 -0) ➕ `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/PasswordStrengthIndicatorTest.kt` (+42 -0) </details> ### 📄 Description Builds of #3787 just wanted to break that up since I was modifying some shared code. https://github.com/user-attachments/assets/0a6c656b-8ccd-4ea2-b4f4-67b1856b7679 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:44:18 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4424
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?