github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #788] [CLOSED] Project lib updates and migration #44190

New Issue
Closed
opened 2026-04-26 11:25:46 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-26 11:25:46 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/788
Author: @mpbw2
Created: 3/20/2020
Status: ❌ Closed

Base: master ← Head: lib-migration

📝 Commits (10+)

📊 Changes

32 files changed (+211 additions, -15859 deletions)

View changed files

📝 .gitignore (+15 -5)
📝 src/Android/Android.csproj (+13 -18)
➕ src/Android/Effects/FabShadowEffect.cs (+29 -0)
📝 src/Android/Effects/FixedSizeEffect.cs (+2 -5)
📝 src/Android/Effects/SelectableLabelEffect.cs (+2 -5)
📝 src/Android/Effects/TabBarEffect.cs (+3 -4)
📝 src/Android/MainActivity.cs (+1 -1)
📝 src/Android/MainApplication.cs (+0 -2)
📝 src/Android/Properties/AndroidManifest.xml (+2 -2)
📝 src/Android/Renderers/ExtendedSliderRenderer.cs (+1 -1)
➖ src/Android/Resources/Resource.designer.cs (+0 -15693)
📝 src/Android/Resources/layout/Tabbar.axml (+1 -1)
📝 src/Android/Resources/layout/Toolbar.axml (+1 -1)
📝 src/Android/Services/DeviceActionService.cs (+2 -2)
➖ src/Android/Utilities/CustomFingerprintDialogFragment.cs (+0 -30)
📝 src/App/App.csproj (+5 -5)
➕ src/App/Effects/FabShadowEffect.cs (+11 -0)
📝 src/App/Pages/Settings/FoldersPage.xaml (+9 -4)
📝 src/App/Pages/Settings/FoldersPage.xaml.cs (+0 -4)
📝 src/App/Pages/Vault/AutofillCiphersPage.xaml (+8 -4)

...and 12 more files

📄 Description

Summary:

Update to all 3rd party libs used in the project. Please make sure you're using the latest stable Visual Studio (just recently updated) as well as the latest Xamarin.Android and Xamarin.iOS SDKs. If using Rider, make sure it's referencing the Xamarin SDKs from Visual Studio (the built-in versions aren't recent enough)

Occasionally when installing to Android the following error may occur:

The "CopyGeneratedJavaResourceClasses" task was not given a value for the required parameter "SourceTopDirectory".

Simply re-run the install process and it should proceed normally.

Additional Details:

Minimum supported Android version now 5.0 (SDK 21)

  • Removed MultiDex support as Android 5.0+ runtime supports multiple dex natively

Xamarin.Forms: Updated to 4.5.0.356 (from 4.4.0.991265)

Xamarin.Essentials: Updated to 1.5.1 (from 1.3.1)

Xamarin.Android.Support*: Updated to all appropriate Xamarin.AndroidX* and Xamarin.Google* libs

  • Updated all relevant imports

Xamarin.Firebase.Messaging: Updated to 71.1740.0 (from 60.1142.1)

Portable.BouncyCastle: Updated to 1.8.6 (from 1.8.5.2)

LiteDB: Updated to 5.0.4 (from 4.1.4) which required these modifications:

  • Changed _collection type to ILiteCollection (from LiteCollection)
  • Added Upgrade=true; to DB constructor as the DB file format was changed
  • Changed collection .Delete to .DeleteMany to support the existing expression

Plugin.Fingerprint: Updated to 2.1.1 (from 1.4.9) which required these modifications:

  • Removed CustomFingerprintDialogFragment.cs as it's no longer necessary
  • Added second text arg in AuthenticationRequestConfiguration constructor as the usage now varies between platforms

ZXing.Net.Mobile.Forms: Updated to 2.4.1 (from 2.1.47)

ZXing.Net.Mobile: Added 2.4.1 as it's now required alongside ZXing.Net.Mobile.Forms)

Refractored.FloatingActionButtonForms: Removed as it's not compatible with Forms 4.5 & AndroidX

  • Replaced with visibly identical custom implementation, no lib required

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/788 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 3/20/2020 **Status:** ❌ Closed **Base:** `master` ← **Head:** `lib-migration` --- ### 📝 Commits (10+) - [`b0efc86`](https://github.com/bitwarden/android/commit/b0efc862712d177da561eae8ae4537060b0faa51) Replace 3rd party FAB lib with our own code - [`3c2d9be`](https://github.com/bitwarden/android/commit/3c2d9becd5d2591f2173497285762d3ee583680e) merged - [`373057f`](https://github.com/bitwarden/android/commit/373057f8c14e7b35f9d9c4f589aa2c9b58c95337) merged - [`ed6f4bf`](https://github.com/bitwarden/android/commit/ed6f4bf1844be25106db8320d0952bc325ab75ac) WIP - [`354fdce`](https://github.com/bitwarden/android/commit/354fdce326bacd253271df57d5a6392ed22acae7) WIP - [`a56dc7d`](https://github.com/bitwarden/android/commit/a56dc7d8032eac65e7e1c6869fccba47c0f5f9de) Updated .gitignore with latest from Xamarin repo and removed Android Resource.designer.cs file (#781) - [`0722e4e`](https://github.com/bitwarden/android/commit/0722e4e716ba3a65c1890f7b7a9657b5d56b7463) WIP - [`262528a`](https://github.com/bitwarden/android/commit/262528a3a572a021d929618a2bb6de69ee81b203) WIP - [`7ea9f83`](https://github.com/bitwarden/android/commit/7ea9f83eb6437416e8da0f8720ab8e49acbc4ea3) Sanitize Password Length (#783) - [`4407789`](https://github.com/bitwarden/android/commit/4407789f29060077916eaf20a1a08b7f7472dd78) Add support for inverse data matrix QR codes (#787) ### 📊 Changes **32 files changed** (+211 additions, -15859 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+15 -5) 📝 `src/Android/Android.csproj` (+13 -18) ➕ `src/Android/Effects/FabShadowEffect.cs` (+29 -0) 📝 `src/Android/Effects/FixedSizeEffect.cs` (+2 -5) 📝 `src/Android/Effects/SelectableLabelEffect.cs` (+2 -5) 📝 `src/Android/Effects/TabBarEffect.cs` (+3 -4) 📝 `src/Android/MainActivity.cs` (+1 -1) 📝 `src/Android/MainApplication.cs` (+0 -2) 📝 `src/Android/Properties/AndroidManifest.xml` (+2 -2) 📝 `src/Android/Renderers/ExtendedSliderRenderer.cs` (+1 -1) ➖ `src/Android/Resources/Resource.designer.cs` (+0 -15693) 📝 `src/Android/Resources/layout/Tabbar.axml` (+1 -1) 📝 `src/Android/Resources/layout/Toolbar.axml` (+1 -1) 📝 `src/Android/Services/DeviceActionService.cs` (+2 -2) ➖ `src/Android/Utilities/CustomFingerprintDialogFragment.cs` (+0 -30) 📝 `src/App/App.csproj` (+5 -5) ➕ `src/App/Effects/FabShadowEffect.cs` (+11 -0) 📝 `src/App/Pages/Settings/FoldersPage.xaml` (+9 -4) 📝 `src/App/Pages/Settings/FoldersPage.xaml.cs` (+0 -4) 📝 `src/App/Pages/Vault/AutofillCiphersPage.xaml` (+8 -4) _...and 12 more files_ </details> ### 📄 Description **Summary**: Update to all 3rd party libs used in the project. Please make sure you're using the latest stable Visual Studio (just recently updated) as well as the latest Xamarin.Android and Xamarin.iOS SDKs. If using Rider, make sure it's referencing the Xamarin SDKs from Visual Studio (the built-in versions aren't recent enough) Occasionally when installing to Android the following error may occur: `The "CopyGeneratedJavaResourceClasses" task was not given a value for the required parameter "SourceTopDirectory".` Simply re-run the install process and it should proceed normally. **Additional Details**: Minimum supported Android version now `5.0` (SDK `21`) - Removed `MultiDex` support as Android 5.0+ runtime supports multiple dex natively `Xamarin.Forms`: Updated to `4.5.0.356` (from `4.4.0.991265`) `Xamarin.Essentials`: Updated to `1.5.1` (from `1.3.1`) `Xamarin.Android.Support*`: Updated to all appropriate `Xamarin.AndroidX*` and `Xamarin.Google*` libs - Updated all relevant imports `Xamarin.Firebase.Messaging`: Updated to `71.1740.0` (from `60.1142.1`) `Portable.BouncyCastle`: Updated to `1.8.6` (from `1.8.5.2`) `LiteDB`: Updated to `5.0.4` (from `4.1.4`) which required these modifications: - Changed `_collection` type to `ILiteCollection` (from `LiteCollection`) - Added `Upgrade=true;` to DB constructor as the DB file format was changed - Changed collection `.Delete` to `.DeleteMany` to support the existing expression `Plugin.Fingerprint`: Updated to `2.1.1` (from `1.4.9`) which required these modifications: - Removed `CustomFingerprintDialogFragment.cs` as it's no longer necessary - Added second `text` arg in `AuthenticationRequestConfiguration` constructor as the usage now varies between platforms `ZXing.Net.Mobile.Forms`: Updated to `2.4.1` (from `2.1.47`) `ZXing.Net.Mobile`: Added `2.4.1` as it's now required alongside `ZXing.Net.Mobile.Forms`) `Refractored.FloatingActionButtonForms`: Removed as it's not compatible with Forms 4.5 & AndroidX - Replaced with visibly identical custom implementation, no lib required --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-26 11:25:46 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#44190
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?