github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-18 11:44:32 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #3787] [MERGED] PM-10617 + PM-10637 update complete registration screen to match new onboarding design #4419

New Issue
Closed
opened 2025-11-26 23:44:13 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:44:13 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/3787
Author: @dseverns-livefront
Created: 8/20/2024
Status: ✅ Merged
Merged: 8/21/2024
Merged by: @dseverns-livefront

Base: main ← Head: PM-10617/new-create-mp-screen

📝 Commits (8)

  • 7404c0e PM-10617 update complete registration screen to match new onboarding spec. Add feature flag check for what to do once account registered.
  • cc2c25f feedback
  • 6337e9b add dark mode asset
  • dd3b434 Update nav events to nav to login
  • ac1ea7e Pr feedback
  • 5146169 a thing
  • 68f07db mll needed
  • 6cba4ff no

📊 Changes

13 files changed (+883 additions, -299 deletions)

View changed files

📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/auth/AuthNavigation.kt (+15 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationNavigation.kt (+6 -2)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationScreen.kt (+230 -119)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt (+82 -57)
➕ app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/handlers/CompleteRegistrationHandler.kt (+86 -0)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountViewModel.kt (+1 -1)
📝 app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordguidance/MasterPasswordGuidanceScreen.kt (+15 -48)
➕ app/src/main/java/com/x8bit/bitwarden/ui/platform/components/card/BitwardenActionCard.kt (+119 -0)
➕ app/src/main/res/drawable-night/lock.xml (+66 -0)
➕ app/src/main/res/drawable/lock.xml (+66 -0)
📝 app/src/main/res/values/strings.xml (+5 -0)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationScreenTest.kt (+129 -23)
📝 app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModelTest.kt (+63 -47)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-10617
&
https://bitwarden.atlassian.net/browse/PM-10637

📔 Objective

  • Update complete registration screen to match new design and function
  • support landscape mode
  • feature flag for what happends next after resgistration

📸 Screenshots

https://github.com/user-attachments/assets/f3ee68cb-656e-472e-893e-544c8cbd246a

pm10617

10617_landscape

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/3787 **Author:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Created:** 8/20/2024 **Status:** ✅ Merged **Merged:** 8/21/2024 **Merged by:** [@dseverns-livefront](https://github.com/dseverns-livefront) **Base:** `main` ← **Head:** `PM-10617/new-create-mp-screen` --- ### 📝 Commits (8) - [`7404c0e`](https://github.com/bitwarden/android/commit/7404c0e5dee5eca06c955df1f5c18d643bf6afd2) PM-10617 update complete registration screen to match new onboarding spec. Add feature flag check for what to do once account registered. - [`cc2c25f`](https://github.com/bitwarden/android/commit/cc2c25fac5fbd4191c3c466082593ef99211fefc) feedback - [`6337e9b`](https://github.com/bitwarden/android/commit/6337e9b39cec4a6e174cca654941c48421c2d69b) add dark mode asset - [`dd3b434`](https://github.com/bitwarden/android/commit/dd3b434d2dc4cb7e9f52e9dad52cfaf76c9fd4ab) Update nav events to nav to login - [`ac1ea7e`](https://github.com/bitwarden/android/commit/ac1ea7eaa678e3f2cd617302810c960697eb038d) Pr feedback - [`5146169`](https://github.com/bitwarden/android/commit/5146169ddddfe944e3cb3a7f9c7643a88003a313) a thing - [`68f07db`](https://github.com/bitwarden/android/commit/68f07db78bb0d25c66b019b79d722e4dc3c2787f) mll needed - [`6cba4ff`](https://github.com/bitwarden/android/commit/6cba4ff78537b72c6bacbc72ee703b5a42f12d9c) no ### 📊 Changes **13 files changed** (+883 additions, -299 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/auth/AuthNavigation.kt` (+15 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationNavigation.kt` (+6 -2) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationScreen.kt` (+230 -119) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModel.kt` (+82 -57) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/handlers/CompleteRegistrationHandler.kt` (+86 -0) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/createaccount/CreateAccountViewModel.kt` (+1 -1) 📝 `app/src/main/java/com/x8bit/bitwarden/ui/auth/feature/masterpasswordguidance/MasterPasswordGuidanceScreen.kt` (+15 -48) ➕ `app/src/main/java/com/x8bit/bitwarden/ui/platform/components/card/BitwardenActionCard.kt` (+119 -0) ➕ `app/src/main/res/drawable-night/lock.xml` (+66 -0) ➕ `app/src/main/res/drawable/lock.xml` (+66 -0) 📝 `app/src/main/res/values/strings.xml` (+5 -0) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationScreenTest.kt` (+129 -23) 📝 `app/src/test/java/com/x8bit/bitwarden/ui/auth/feature/completeregistration/CompleteRegistrationViewModelTest.kt` (+63 -47) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-10617 & https://bitwarden.atlassian.net/browse/PM-10637 <!-- Paste the link to the Jira or GitHub issue or otherwise describe / point to where this change is coming from. --> ## 📔 Objective - Update complete registration screen to match new design and function - support landscape mode - feature flag for what happends next after resgistration <!-- Describe what the purpose of this PR is, for example what bug you're fixing or new feature you're adding. --> ## 📸 Screenshots https://github.com/user-attachments/assets/f3ee68cb-656e-472e-893e-544c8cbd246a ![pm10617](https://github.com/user-attachments/assets/a174912d-8f32-446d-bd5e-e85df57b1a57) ![10617_landscape](https://github.com/user-attachments/assets/2db7dcdd-2fa0-4d38-8f66-223688af84fc) <!-- Required for any UI changes; delete if not applicable. Use fixed width images for better display. --> ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:44:14 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#4419
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?